validates User ID as a string #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeproeng37
suggested changes
Apr 17, 2018
lib/optimizely.rb
Outdated
| @@ -135,8 +135,8 @@ def get_variation(experiment_key, user_id, attributes = nil) | |||
| return nil | |||
| end | |||
|
|
|||
| if user_id.to_s.empty? | |||
| @logger.log(Logger::ERROR, 'User ID cannot be empty.') | |||
| if !user_id.is_a?(String) || user_id.empty? | |||
There was a problem hiding this comment.
This same logic is duplicated in a few places. Can you create a validator function that we re-use?
|
@mikeng13 Please review changes. |
mikeproeng37
suggested changes
Apr 18, 2018
| @@ -18,6 +18,7 @@ | |||
| require_relative 'constants' | |||
| require 'json' | |||
| require 'json-schema' | |||
| require 'optimizely/logger' | |||
There was a problem hiding this comment.
Can this be a relative require since this module is in the Optimizely module?
| @@ -306,6 +306,12 @@ module Constants | |||
| 'INTEGER' => 'integer', | |||
| 'STRING' => 'string' | |||
| }.freeze | |||
|
|
|||
| INPUT_VARIABLES = { | |||
| 'user_id' => 'User ID', | |||
There was a problem hiding this comment.
If you look at VARIABLE_TYPES the keys are all caps. Let's keep it consistent here.
|
build |
|
@mikeng13 All inputs validation is implemented in PR- #103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.