Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _get_distribution from visualization/matplotlib/_param_importances.py #2604

Merged
merged 1 commit into from Apr 20, 2021

Conversation

nzw0301
Copy link
Collaborator

@nzw0301 nzw0301 commented Apr 19, 2021

Motivation

The internal method, _get_distribution, has never been used in optuna since #2576.

Description of the changes

Remove _get_distribution.

@github-actions github-actions bot added the optuna.visualization Related to the `optuna.visualization` submodule. This is automatically labeled by github-actions. label Apr 19, 2021
@nzw0301 nzw0301 changed the title Remove unused method, _get_distribution, from visualization/matplotlib/_param_importances.py Remove _get_distribution from visualization/matplotlib/_param_importances.py Apr 19, 2021
@hvy hvy self-assigned this Apr 20, 2021
Copy link
Member

@hvy hvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM!

@hvy hvy added the code-fix Change that does not change the behavior, such as code refactoring. label Apr 20, 2021
@hvy hvy merged commit b5fd043 into optuna:master Apr 20, 2021
@hvy hvy added this to the v2.8.0 milestone Apr 20, 2021
@nzw0301 nzw0301 deleted the remove-unused-method branch April 20, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-fix Change that does not change the behavior, such as code refactoring. optuna.visualization Related to the `optuna.visualization` submodule. This is automatically labeled by github-actions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants