From 2754d269076c7139c882ba5b732daad20f91ea7a Mon Sep 17 00:00:00 2001 From: Kento Nozawa Date: Sat, 14 May 2022 20:55:07 +0900 Subject: [PATCH 1/2] Remove the version constraint of fakeredis --- setup.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/setup.py b/setup.py index 29347a9f16..d835349ea1 100644 --- a/setup.py +++ b/setup.py @@ -94,8 +94,7 @@ def get_extras_require() -> Dict[str, List[str]]: "testing": [ "chainer>=5.0.0", "cma", - # TODO(HideakiImamura): Remove the version constraint after the next release. - "fakeredis<=1.7.1", + "fakeredis", "lightgbm", "matplotlib>=3.0.0", "mlflow", @@ -128,8 +127,7 @@ def get_extras_require() -> Dict[str, List[str]]: "fastai ; python_version>'3.6' and python_version<'3.10'", ], "tests": [ - # TODO(HideakiImamura): Remove the version constraint after the next release. - "fakeredis<=1.7.1", + "fakeredis", "pytest", ], "optional": [ From 149fcaf9238b6f0b6f572288f4092de4392bb6d9 Mon Sep 17 00:00:00 2001 From: Kento Nozawa Date: Sun, 15 May 2022 01:02:10 +0900 Subject: [PATCH 2/2] Add python version condition for fakeredis --- setup.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index d835349ea1..032014f165 100644 --- a/setup.py +++ b/setup.py @@ -94,7 +94,8 @@ def get_extras_require() -> Dict[str, List[str]]: "testing": [ "chainer>=5.0.0", "cma", - "fakeredis", + "fakeredis<=1.7.1; python_version<'3.8'", + "fakeredis ; python_version>='3.8'", "lightgbm", "matplotlib>=3.0.0", "mlflow", @@ -127,7 +128,8 @@ def get_extras_require() -> Dict[str, List[str]]: "fastai ; python_version>'3.6' and python_version<'3.10'", ], "tests": [ - "fakeredis", + "fakeredis<=1.7.1; python_version<'3.8'", + "fakeredis ; python_version>='3.8'", "pytest", ], "optional": [