Fix integration tests to run with instance_principal #339

liudmylaru · 2023-09-20T18:36:19Z

Description

After we setup integration tests to run with instance principals we got 42 tests failed. This PR is to address integration tests and opctl tests. More fixes will follow in future PRs.
Jira for ALL Integration tests: https://jira.oci.oraclecorp.com/browse/ODSC-47592 (details in comments in subtasks)
Jira for OPCTL tests: https://jira.oci.oraclecorp.com/browse/ODSC-47603

In addition to code changed in the tests in this PR, there were updated done to Dynamic Groups and Policy so that instance principal will work with logs, buckets and dataflow service.

What was done

removed hardcoded config path from "jobs" folder
added if to update kwargs with default_signer in jobs serializer write_to_fle
updated tests in "other" folder - mainly harcdoded ~/.oci/config
fixed check-docstring-first pre-commit check in serializer.py
updated opctl integration tests and fixed issues

Pre-commit

check python ast.........................................................Passed
check docstring is first.............................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
check yaml...........................................(no files to check)Skipped
detect private key.......................................................Passed
fix end of files.........................................................Passed
pretty format json...................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
black....................................................................Passed
rst ``code`` is two backticks........................(no files to check)Skipped
rst ``inline code`` next to normal text..............(no files to check)Skipped
Detect hardcoded secrets.................................................Passed
check-copyright..........................................................Passed
[ODSC-47592/fix_int_test_jobs_python_runtime 5455bfb] ODSC-47592. Fix test_jobs_python_runtime.py

Integration tests

Integration tests (no opctl included) passed with Python3.9:

Integration OPCTL tests passed on Python3.8:

github-actions · 2023-09-20T18:36:36Z

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

github-actions · 2023-09-20T19:36:54Z

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

github-actions · 2023-09-20T19:38:34Z

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

github-actions · 2023-09-20T20:23:49Z

⚠️ This PR changed pyproject.toml file. ⚠️

PR Creator must update 📃 THIRD_PARTY_LICENSES.txt, if any 📚 library added/removed in pyproject.toml.
PR Approver must confirm 📃 THIRD_PARTY_LICENSES.txt updated, if any 📚 library added/removed in pyproject.toml.

github-actions · 2023-09-20T20:24:13Z

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

mrDzurb · 2023-09-20T20:46:12Z

ads/jobs/serializer.py


+        # Add default signer if the uri is an object storage uri, and
+        # the user does not specify config or signer.
+        if (


Do we really need to check on the "oci://"?

I just copied lines 94-99 (https://github.com/oracle/accelerated-data-science/blob/main/ads/jobs/serializer.py#L94-L99) from the same file, I think QQ told me he forgot to add this code here also. So my answer to your question - I do not know :)

if the uri does not start with oci://, the config and signer are not needed. Also we don't want to send the credentials to non-oci server (which could be a security issue).

github-actions · 2023-09-20T21:20:35Z

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

- removed hardcoded config path from test_dsc_job.py - added if to update kwargs with default_signer in jobs serializer write_to_fle - fixed check-docstring-first pro-commit check in serializer.py

- fix test_jobs_cli.py - fix test_jobs_notebook.py

- fix test_jobs_cli.py - fix test_jobs_runs.py

- fix test_jobs_cli.py

- updated driver_utils.py to work with Instance Principals - added default_signer() into test_notebook_driver_with_outputs()

github-actions · 2023-11-07T22:26:54Z

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

- set OCI_IAM_TYPE env var for run driver in jobs tests

github-actions · 2023-11-08T15:56:35Z

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

- fix typo in test_jobs_cli.py

github-actions · 2023-11-08T17:44:42Z

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

- updated tests in "other" folder

github-actions · 2023-11-08T18:56:14Z

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

- rollback changes in driver_utils.py - fix test_jobs_cli.py - fix test_artifact_saving_data.py

github-actions · 2023-11-08T21:54:55Z

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

- update env_vars to run_driver()

github-actions · 2023-11-08T22:15:34Z

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

- mark test_notebook_driver_with_outputs() skipped

github-actions · 2023-11-08T23:42:39Z

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

- fixes to OPCLT int tests

github-actions · 2023-11-10T16:09:52Z

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

- fixes to OPCLT int tests

github-actions · 2023-11-10T16:23:34Z

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

- fixes to OPCTL int tests - marked skipped one data_flow test

github-actions · 2023-11-13T20:08:46Z

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

github-actions · 2023-11-14T01:07:48Z

📌 Cov diff with main:

📌 Overall coverage:

qiuosier · 2023-11-14T14:34:18Z

ads/jobs/serializer.py


+        # Add default signer if the uri is an object storage uri, and
+        # the user does not specify config or signer.
+        if (


if the uri does not start with oci://, the config and signer are not needed. Also we don't want to send the credentials to non-oci server (which could be a security issue).

oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 20, 2023

liudmylaru changed the title ~~ODSC-47592. Fix test_jobs_python_runtime.py~~ Fix test_jobs_python_runtime.py Sep 20, 2023

mrDzurb previously approved these changes Sep 20, 2023

View reviewed changes

liudmylaru added 5 commits November 7, 2023 13:08

ODSC-47592. Fix test_jobs_python_runtime.py

4f27300

- removed hardcoded config path from test_dsc_job.py - added if to update kwargs with default_signer in jobs serializer write_to_fle - fixed check-docstring-first pro-commit check in serializer.py

ODSC-47592. Fix test_jobs_python_runtime.py

54b53d9

- fix test_jobs_cli.py - fix test_jobs_notebook.py

ODSC-47592. Fix test_jobs_python_runtime.py

22efebb

- fix test_jobs_cli.py - fix test_jobs_runs.py

ODSC-47592. Fix test_jobs_python_runtime.py

c4e5e7f

- fix test_jobs_cli.py

ODSC-47592. Fix test_jobs_python_runtime.py

969e15d

- updated driver_utils.py to work with Instance Principals - added default_signer() into test_notebook_driver_with_outputs()

liudmylaru dismissed mrDzurb’s stale review via 969e15d November 7, 2023 22:25

liudmylaru force-pushed the ODSC-47592/fix_int_test_jobs_python_runtime branch from 5b1dd56 to 969e15d Compare November 7, 2023 22:25

ODSC-47592. Fix test_jobs_python_runtime.py

0310b04

- set OCI_IAM_TYPE env var for run driver in jobs tests

ODSC-47592. Fix test_jobs_python_runtime.py

e44ff80

- fix typo in test_jobs_cli.py

ODSC-47592. Fix test_jobs_python_runtime.py

e01dfd3

- updated tests in "other" folder

ODSC-47592. Fix test_jobs_python_runtime.py

92f88a9

- rollback changes in driver_utils.py - fix test_jobs_cli.py - fix test_artifact_saving_data.py

liudmylaru changed the title ~~Fix test_jobs_python_runtime.py~~ Fix integration tests to run with instance_principal Nov 8, 2023

ODSC-47592. Fix test_jobs_python_runtime.py

7fdf734

- update env_vars to run_driver()

ODSC-47592. Fix test_jobs_python_runtime.py

5455bfb

- mark test_notebook_driver_with_outputs() skipped

ODSC-47592. Fix test_jobs_python_runtime.py

78fb596

- fixes to OPCLT int tests

ODSC-47592. Fix test_jobs_python_runtime.py

30dff05

- fixes to OPCLT int tests

ODSC-47592. Fix test_jobs_python_runtime.py

f58cdc5

- fixes to OPCTL int tests - marked skipped one data_flow test

liudmylaru requested a review from mrDzurb November 13, 2023 20:34

Merge branch 'main' into ODSC-47592/fix_int_test_jobs_python_runtime

4acee25

mrDzurb approved these changes Nov 14, 2023

View reviewed changes

qiuosier approved these changes Nov 14, 2023

View reviewed changes

liudmylaru merged commit c8ed767 into main Nov 14, 2023

liudmylaru deleted the ODSC-47592/fix_int_test_jobs_python_runtime branch November 14, 2023 15:11

Fix integration tests to run with instance_principal #339

Fix integration tests to run with instance_principal #339

Conversation

liudmylaru commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

What was done

Pre-commit

Integration tests

Uh oh!

github-actions bot commented Sep 20, 2023

Uh oh!

github-actions bot commented Sep 20, 2023

Uh oh!

github-actions bot commented Sep 20, 2023

Uh oh!

github-actions bot commented Sep 20, 2023

Uh oh!

github-actions bot commented Sep 20, 2023

Uh oh!

mrDzurb Sep 20, 2023

Choose a reason for hiding this comment

Uh oh!

liudmylaru Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qiuosier Nov 14, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 20, 2023

Uh oh!

github-actions bot commented Nov 7, 2023

Uh oh!

github-actions bot commented Nov 8, 2023

Uh oh!

github-actions bot commented Nov 8, 2023

Uh oh!

github-actions bot commented Nov 8, 2023

Uh oh!

github-actions bot commented Nov 8, 2023

Uh oh!

github-actions bot commented Nov 8, 2023

Uh oh!

github-actions bot commented Nov 8, 2023

Uh oh!

github-actions bot commented Nov 10, 2023

Uh oh!

github-actions bot commented Nov 10, 2023

Uh oh!

github-actions bot commented Nov 13, 2023

Uh oh!

github-actions bot commented Nov 14, 2023

Uh oh!

qiuosier Nov 14, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

liudmylaru commented Sep 20, 2023 •

edited

Loading

liudmylaru Nov 8, 2023 •

edited

Loading