Skip to content

Fixed model deployment failed return value #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 14, 2023
Merged

Fixed model deployment failed return value #421

merged 10 commits into from
Nov 14, 2023

Conversation

@lu-ohai
Copy link
Member

@lu-ohai lu-ohai commented Nov 13, 2023 •
edited
Loading

Fixed model deployment failed return value

  • Every time when a service error raises, log this error and return the model deployment object. The model deployment object can continue calling logging
  • Raise error for model deployment that's not in ACTIVE state

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 13, 2023
@github-actions
Copy link

github-actions bot commented Nov 13, 2023

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

@lu-ohai lu-ohai marked this pull request as ready for review November 13, 2023 15:25
@lu-ohai lu-ohai requested review from mayoor and mrDzurb November 13, 2023 15:25
@github-actions
Copy link

github-actions bot commented Nov 13, 2023

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

VipulMascarenhas
VipulMascarenhas reviewed Nov 13, 2023
View reviewed changes
VipulMascarenhas
VipulMascarenhas reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@VipulMascarenhas VipulMascarenhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewing PR to understand the codebase/changes. I have a question regarding the checks failing - is that expected or those are run/tested locally?

@lu-ohai
Copy link
Member Author

lu-ohai commented Nov 13, 2023

reviewing PR to understand the codebase/changes. I have a question regarding the checks failing - is that expected or those are run/tested locally?

I think it's some issue related to the github: https://github.com/oracle/accelerated-data-science/actions/runs/6852181858/job/18630113404?pr=421

@github-actions
Copy link

github-actions bot commented Nov 13, 2023

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

@github-actions
Copy link

github-actions bot commented Nov 13, 2023

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

@lu-ohai lu-ohai force-pushed the ODSC-49328/fix_failed_model_deployment_return_value branch from 3c16701 to 3ad2e73 Compare November 14, 2023 00:50
@lu-ohai
Merge branch 'main' of https://github.com/oracle/accelerated-data-sci…
355cde0 
…ence into ODSC-49328/fix_failed_model_deployment_return_value
@github-actions
Copy link

github-actions bot commented Nov 14, 2023

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

2 similar comments
@github-actions
Copy link

github-actions bot commented Nov 14, 2023

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

@github-actions
Copy link

github-actions bot commented Nov 14, 2023

📌 Cov diff with main:

No success to gather report. 😿

📌 Overall coverage:

No success to gather report. 😿

@github-actions
Copy link

github-actions bot commented Nov 14, 2023

📌 Cov diff with main:

Coverage-43%

📌 Overall coverage:

Coverage-68.70%

@github-actions
Copy link

github-actions bot commented Nov 14, 2023

📌 Cov diff with main:

Coverage-66%

📌 Overall coverage:

Coverage-71.46%

mrDzurb
mrDzurb reviewed Nov 14, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 14, 2023

📌 Cov diff with main:

Coverage-33%

📌 Overall coverage:

Coverage-71.50%

@liudmylaru liudmylaru self-requested a review November 14, 2023 22:33
@lu-ohai lu-ohai merged commit 4d10e47 into main Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VipulMascarenhas VipulMascarenhas VipulMascarenhas left review comments

@mrDzurb mrDzurb mrDzurb approved these changes

@liudmylaru liudmylaru liudmylaru approved these changes

@mayoor mayoor Awaiting requested review from mayoor mayoor is a code owner

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lu-ohai @mrDzurb @VipulMascarenhas @liudmylaru