diff --git a/ads/feature_store/common/utils/transformation_utils.py b/ads/feature_store/common/utils/transformation_utils.py index 6ac0786f1..3097ed7c7 100644 --- a/ads/feature_store/common/utils/transformation_utils.py +++ b/ads/feature_store/common/utils/transformation_utils.py @@ -52,9 +52,7 @@ def apply_transformation( # Execute the function under namespace execution_namespace = {} exec(transformation_function, execution_namespace) - transformation_function_caller = execution_namespace.get( - transformation.name - ) + transformation_function_caller = execution_namespace.get(transformation.name) transformed_data = None transformation_kwargs_dict = json.loads(transformation_kwargs) diff --git a/ads/feature_store/execution_strategy/spark/spark_execution.py b/ads/feature_store/execution_strategy/spark/spark_execution.py index bfc89ff39..450ad900d 100644 --- a/ads/feature_store/execution_strategy/spark/spark_execution.py +++ b/ads/feature_store/execution_strategy/spark/spark_execution.py @@ -366,7 +366,10 @@ def update_feature_definition_features(self, feature_group, target_table): try: # Get the output features output_features = get_features( - self.spark_engine.get_output_columns_from_table_or_dataframe(table_name=target_table), feature_group.id + self.spark_engine.get_output_columns_from_table_or_dataframe( + table_name=target_table + ), + feature_group.id, ) if output_features: feature_group._with_features(output_features) @@ -392,7 +395,9 @@ def update_dataset_features(self, dataset, target_table): try: # Get the output features output_features = get_features( - output_columns=self.spark_engine.get_output_columns_from_table_or_dataframe(table_name=target_table), + output_columns=self.spark_engine.get_output_columns_from_table_or_dataframe( + table_name=target_table + ), parent_id=dataset.id, entity_type=EntityType.DATASET, ) diff --git a/ads/feature_store/feature_store.py b/ads/feature_store/feature_store.py index ea985652b..cbf3e54b1 100644 --- a/ads/feature_store/feature_store.py +++ b/ads/feature_store/feature_store.py @@ -367,9 +367,7 @@ def create_entity( "FeatureStore Resource must be created or saved before creating the entity." ) - self.oci_fs_entity = self._build_entity( - name, description, compartment_id - ) + self.oci_fs_entity = self._build_entity(name, description, compartment_id) return self.oci_fs_entity.create() def delete_entity(self): diff --git a/ads/feature_store/transformation.py b/ads/feature_store/transformation.py index 93c04d638..67d44af38 100644 --- a/ads/feature_store/transformation.py +++ b/ads/feature_store/transformation.py @@ -346,13 +346,14 @@ def create(self, **kwargs) -> "Transformation": if not self.source_code_function: raise ValueError("Transformation source code function must be provided.") + if not self.transformation_mode: + raise ValueError("Transformation Mode must be provided.") + if not self.name: self.name = self._transformation_function_name if self.name != self._transformation_function_name: - raise ValueError( - "Transformation name and function name must be same." - ) + raise ValueError("Transformation name and function name must be same.") payload = deepcopy(self._spec) payload.pop("id", None)