Skip to content

Fix incremental models failing with ORA-00955 by ignoring database parameter in get_relation() #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incremental models failing with ORA-00955 by ignoring database parameter in get_relation() #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions dbt/adapters/oracle/impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,10 @@ def timestamp_add_sql(
return f"{add_to} + interval '{number}' {interval}"

def get_relation(self, database: str, schema: str, identifier: str) -> Optional[BaseRelation]:
if database == 'None':
database = self.config.credentials.database
return super().get_relation(database, schema, identifier)
# In Oracle the database parameter doesn't apply to relation lookups,
# it uses SCHEMA.TABLE, not DATABASE.SCHEMA.TABLE
# Use None for consistent cache lookups regardless of database parameter in profiles.yml.
return super().get_relation(None, schema, identifier)

def _get_one_catalog_by_relations(
self,
Expand Down