Appstore does not accept apps using private CF API's

[johanvos]

When submitting an app build using Graal to the AppStore, the app was rejected and the following message was received:

The app references non-public symbols in App: __CFCopyServerVersionDictionary, __CFCopySystemVersionDictionary.
This is due to _CFCopyServerVersionDictionary and _CFCopySystemVersionDictionary in com.oracle.svm.core.posix.headers.darwin.
Those functions are used in com.oracle.svm.core.posix.darwin.DarwinSystemPropertiesSupport.osVersionValue and they should probably be replaced with "non-internal" functions.

[johanvos]

FWIW, by removing these 2 methods, we could upload an app to the AppStore without issues.

[olpaw]

@johanvos is this still relevant? Can we close the issue?

[johanvos]

It is still relevant. I'll create a PR for this.

[johanvos]

The approach for getting the system os version in GraalVM is not allowed by Apple (at least, apps that use it can not be uploaded to the App Store (ios) or Apple Store (mac)) because it is using an internal CoreFoundation API.

The approach taken in OpenJDK is valid for Apple though: https://github.com/openjdk/jdk/blob/master/src/java.base/macosx/native/libjava/java_props_macosx.c#L237 -- but I don't see an easy way to replace the Java code in

graal/substratevm/src/com.oracle.svm.core.posix/src/com/oracle/svm/core/posix/darwin/DarwinSystemPropertiesSupport.java

Line 73 in 494b82e

CoreFoundation.CFDictionaryRef dict = CoreFoundation._CFCopyServerVersionDictionary();

with the approach used in the hotspot code