No-op module reflection modifications. #1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobmcwhirter
force-pushed
the
module-reflection-noop
branch
4 times, most recently
from
cbfe3ac to
00065b7
Compare
|
Ping? |
bobmcwhirter
force-pushed
the
module-reflection-noop
branch
from
00065b7 to
7b63bec
Compare
There was a problem hiding this comment.
It seems like a good investment for the future to move this file with all substitutions into the project com.oracle.svm.core.jdk11. That way we can gradually add "real" implementations of these methods when necessary.
Also please add a big disclaimer comment in the file stating that all implementations are currently empty stubs that are only designed to get code running that actually does not use the module system.
Other than that, I'm fine with adding these empty stubs.
|
The Happy to move it though. |
|
Actually, can't move it due to |
The WeakPairMap inside Module$ReflectionData was changing, sometimes, during heap generation of native-image. Delete the class and no-op the relevant methods that used it. Might be a sub-optimal solution, but avoids spurious native-image failures at this point when using JDK11+.
bobmcwhirter
force-pushed
the
module-reflection-noop
branch
from
105748f to
83863f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WeakPairMap inside Module$ReflectionData was changing,
sometimes, during heap generation of native-image.
Delete the class and no-op the relevant methods that used it.
Might be a sub-optimal solution, but avoids spurious native-image
failures at this point when using JDK11+.