Consistently dispose PolyglotEngine after being used in tests #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @chrisseaton, your Ruby check in Truffle Travis seems useful: https://travis-ci.org/graalvm/truffle/builds/117651536 - I've created jruby/jruby#3749 to suggest a change that would play OK with this pull request. All the other languages I am aware of should be OK from this point of view - they have already been creating new instance of |
|
With my latest changes the |
|
Looks good to me. |
…ruffleTCK and its implementor a chance to co-operate on construction of new PolyglotEngine.
jtulach
force-pushed
the
DisposePolyglotEngine
branch
from
48df3e8 to
a4d9f09
Compare
jtulach
pushed a commit
that referenced
this pull request
Mar 22, 2016
Consistently dispose PolyglotEngine after being used in tests
jerboaa
pushed a commit
to jerboaa/graal
that referenced
this pull request
Aug 21, 2025
[Backport] [GR-61888] Fix @Uninterruptible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistently dispose PolyglotEngine after being used in tests. Give TruffleTCK and its implementor a chance to co-operate on construction of new PolyglotEngine.
Yesterday Andreas @woess noted that the change proposed in #85 is huge. I took a look and yes, it seems huge as it contains a lot of fixes in tests. These fixes are however independent of the #85 change - they just consistently dispose
PolyglotEngineafter it has been used. I believe this kind of robustness improving changes can go in without any delay. Thus I am starting this pull request.In addition to that there is one change in
TruffleTCKto allow the TCK and the tested language to co-operate on creation of aPolyglotEngine- such factory is needed not only for #85, but also to test import of symbols - the TCK needs to pre-register them into the builder which will be possible with this new method.