Aarch64 tbz patch #225
Merged
Aarch64 tbz patch #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel22
reviewed
Jun 16, 2017
| * @param uimm6 Unsigned 6-bit bit index. | ||
| * @param imm16 signed 16 bit offset | ||
| * @param pos Position at which instruction is inserted into buffer. -1 means insert at end. | ||
| */ |
There was a problem hiding this comment.
It seems like you could optionally factor out tbz and tbnz into a common function called e.g. testBitAndBranch, and pass only the encoding to it.
I have no strong feelings, however - as you prefer.
There was a problem hiding this comment.
Yes, I suppose I could but I don't see it as anything to worry much about.
There was a problem hiding this comment.
Sounds great, should land soon then!
|
LGTM, with an optional comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a problem introduced into AArch64 by a previous truffle compiler fix.
Testing:
The patch fixes all the unit tests which were failing because of a broken tbz implementation.
n.b. 12 CountedLoop tests are still failing but that is due to an unrelated error to do with missing frame state for a SafeSignedDiv node