Skip to content

Conversation

@adinn
Copy link
Collaborator

@adinn adinn commented Jul 11, 2017

This patch fixes the problem reported here: #236

The patch includes a unit test which manifest the problem and confirms the fix as described in the issyue mentioned above.

@dougxc dougxc self-requested a review July 11, 2017 12:09
@dougxc dougxc self-assigned this Jul 11, 2017
@dougxc
Copy link
Member

dougxc commented Jul 11, 2017

lgtm

@dougxc
Copy link
Member

dougxc commented Jul 11, 2017

I've started the process for integrating this. I reverted the change in JVMCIVersionCheck as it forces us to prepare a 177 binary internally. The only change really needed is in .travis.yml.

@adinn
Copy link
Collaborator Author

adinn commented Jul 11, 2017

Ok, great. Thanks very much.

@adinn adinn force-pushed the stack_store_move_patch branch from 492f60f to 81d4892 Compare July 12, 2017 15:47
@adinn
Copy link
Collaborator Author

adinn commented Jul 12, 2017

I have deleted the unused var stackCopy. I did not detect this error when I ran the eclipseformat command. Is this the right command? Do I need to provide some other arguments to mx?

@dougxc
Copy link
Member

dougxc commented Jul 13, 2017

This should do it: mx clean; mx build --jdt /path/to/ecj-4.5.1.jar --warning-as-error
You can get ecj-4.5.1.jar here.

@dougxc dougxc merged commit c709b1e into oracle:master Jul 17, 2017
@adinn adinn deleted the stack_store_move_patch branch July 21, 2017 10:24
@dougxc dougxc added the accept label Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants