Skip to content

Conversation

@nick-arm
Copy link
Contributor

@nick-arm nick-arm commented May 11, 2020

On AArch64 if the VM jaotc is running in uses compressed oops with a
zero base it will not emit instructions to add/subtract the heap base
when compressing/decompressing oops. This causes a crash if the AOT'd
shared library is loaded into a VM with non-zero heap base.

Fix for JDK-8244164.

…zero heap base

On AArch64 if the VM jaotc is running in uses compressed oops with a
zero base it will not emit instructions to add/subtract the heap base
when compressing/decompressing oops. This causes a crash if the AOT'd
shared library is loaded into a VM with non-zero heap base.

Fix for JDK-8244164.

Change-Id: I9983f6ac81b5ef4a91ce595f61455b90ba1546c3
@graalvmbot
Copy link
Collaborator

Hello Nick Gasson, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address nick -(dot)- gasson -(at)- arm -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

@nick-arm
Copy link
Contributor Author

I'm covered by the OCA signed by Arm Limited

@graalvmbot
Copy link
Collaborator

Nick Gasson has signed the Oracle Contributor Agreement (based on email address nick -(dot)- gasson -(at)- arm -(dot)- com) so can contribute to this repository.

@nick-arm
Copy link
Contributor Author

Any feedback on this? There's a jtreg test that can reproduce this issue here: http://cr.openjdk.java.net/~ngasson/8244164/webrev.0/test/hotspot/jtreg/compiler/aot/TestHeapBase.java.html

@dougxc dougxc assigned dougxc and unassigned veresov May 19, 2020
@dougxc dougxc requested a review from veresov May 19, 2020 09:41
@dougxc
Copy link
Member

dougxc commented May 19, 2020

I'm putting this through the integration process now.

graalvmbot pushed a commit that referenced this pull request May 19, 2020
…s with non-zero heap base (#2446).

PullRequest: graal/6270
@graalvmbot graalvmbot merged commit 62ea6e7 into oracle:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants