Skip to content

Divide can deopt if y is -1 #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2017
Merged

Divide can deopt if y is -1 #266

merged 1 commit into from
Dec 1, 2017

Conversation

@jcdavis
Copy link
Contributor

@jcdavis jcdavis commented Dec 1, 2017 •
edited
Loading

(This is broken as-is due to breaking CountedLoopTest)

@rschatz
Copy link
Member

rschatz commented Dec 1, 2017

The broken CountedLoopTest is a testbug. The test tries to inspect the result of the counted loop detection, but it's doing it too late in the compilation. I'll fix that.

Looks good otherwise. Good catch ;)

@dougxc dougxc requested a review from rschatz December 1, 2017 13:13
@dougxc dougxc merged commit 35bf3e6 into oracle:master Dec 1, 2017
@jcdavis jcdavis deleted the idiv-deopt-fix branch December 2, 2017 07:05
@dougxc dougxc added the accept label Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschatz rschatz Awaiting requested review from rschatz

Assignees

No one assigned

Labels

accept oca-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jcdavis @rschatz @dougxc @graalvmbot