Skip to content

Conversation

@dsamersoff
Copy link
Contributor

Warning! These changes has an impact to the process.

  1. It depends to mx changes (Generate native headers during java compilation graalvm/mx#142).
  2. It's not clear to me how we should handle jdk8 that stay with javah

@dougxc
Copy link
Member

dougxc commented Jan 14, 2018

@rschatz , does this look like the right way to accomodate the removal of javah from recent JDKs?

@rschatz
Copy link
Member

rschatz commented Jan 16, 2018

It's not clear to me how we should handle jdk8 that stay with javah

That's not really a problem, javac on jdk8 does support the -h option. The question is how to support building with ecj/eclipse/netbeans/... I'll look into that.

@rschatz
Copy link
Member

rschatz commented Jan 16, 2018

I made a new PR for mx (graalvm/mx#143) that works around the ecj build issue by still using javah there. With that, this PR should work. We have to wait until the mx change is merged, then I can merge this PR.

Thanks for the contribution.

@dougxc dougxc merged commit ed7ffed into oracle:master Jan 16, 2018
@dsamersoff dsamersoff deleted the javah_deprecation branch January 17, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants