String.compareTo for AArch64 #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed findbugs warning. |
dougxc
reviewed
Mar 26, 2018
There was a problem hiding this comment.
Please check with @mur47x111 whether the fix he made for GR-8748 is also needed here.
There was a problem hiding this comment.
Please apply the same pattern as here to ensure modifiable variables are killed after the intrinsic.
There was a problem hiding this comment.
I don't think we need this @Ignore any more right @mur47x111 ?
There was a problem hiding this comment.
My commit has removed this annotation and reenable the test.
|
Addressed all comments. The fix is ready to push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String compareTo intrinsic for AArch64