Make Message.WRITE final #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eregon yes, the |
|
OK, will do. |
|
Done. |
|
Changing WRITE field to final is correct, but incompatible change. I'd like to do it, but please get wider approval. Write to mailing list and to known language maintainers to confirm they are OK with the change. (Assuming they are) merge then. |
|
I approve of the change. It's an API error and very unlikely somebody depends on it (nobody should ever write to the (WRITE) field), so it should be fixed. |
|
I'll merge this tomorrow. |
|
ready for merging, but needs to be rebased onto master; @eregon |
|
Rebased. |
dougxc
pushed a commit
that referenced
this pull request
May 9, 2016
…/truffle:DebuggerPause to master Debugger.pause * commit '09d076ce607b4e704bf6991df03ee52ab5cbc546': Added Debugger.pause() method. ExecutionEvent is disposable.
zakkak
pushed a commit
to zakkak/mandrel
that referenced
this pull request
Jun 17, 2020
Adds README-Mandrel.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
Messagestatics arefinalexceptWRITE.INSTANCEfields are also not final, but accessed only here, should we make themfinalas well?