Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Epoll if available #3247

Closed
wants to merge 1 commit into from

Conversation

dansiviter
Copy link
Contributor

Open for feedback:

  • As per the issue, defaults to Epoll if available,
  • Unit test is conditional based on if Epoll is available so not to break on Mac or Windows,
  • An abstract NettyTransport which gives scope to add a io_uring (io_uring support is used when available #2670) implementation at a later date with few changes.

@ljnelson
Copy link
Member

ljnelson commented Aug 3, 2021

Note that #2732 exists; I need to rebase it and get it rolling.

@dansiviter
Copy link
Contributor Author

@ljnelson Apologies, I didn't notice your PR. I suppose it depends if Epoll is something that it to defaults to automatically or opt-in to which is the difference between the two approaches.

@ljnelson
Copy link
Member

ljnelson commented Aug 4, 2021

No problem. I think that this should be opt-in: someone building on Windows doesn't want to drag around the dependency for epoll. My PR just checks to see, effectively, if the dependency is on the classpath, and, if so, uses it; otherwise nothing changes. Once I crawl out from my post-vacation inbox I'll rebase the PR and we'll see where it gets to.

@dansiviter
Copy link
Contributor Author

Sure. This was a precursor to trailing io_uring so I'll base that on your pattern.

@dansiviter dansiviter closed this Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants