From e90eae31b05e2c196ab1468d969efa59882e27df Mon Sep 17 00:00:00 2001 From: Chuck Lever Date: Thu, 14 Aug 2025 15:26:23 -0400 Subject: [PATCH 1/3] workflows: Run yamllint against the makefile.yml file makefile.yml 1:1 warning missing document start "---" (document-start) 3:1 warning truthy value should be one of [false, true] (truthy) 3:6 error too many spaces inside brackets (brackets) 3:44 error too many spaces inside brackets (brackets) 20:5 error wrong indentation: expected 6 but found 4 (indentation) 25:81 error line too long (102 > 80 characters) (line-length) Signed-off-by: Chuck Lever --- .github/workflows/makefile.yml | 48 +++++++++++++++++++--------------- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/.github/workflows/makefile.yml b/.github/workflows/makefile.yml index 3a0ee4f..7a2ea4a 100644 --- a/.github/workflows/makefile.yml +++ b/.github/workflows/makefile.yml @@ -1,6 +1,7 @@ +--- name: Multi-platform CI -on: [ push, pull_request, workflow_dispatch ] +on: [push, pull_request, workflow_dispatch] jobs: build: @@ -17,23 +18,28 @@ jobs: - linux/arm64 steps: - - uses: actions/checkout@v4 - - - name: Install dependencies - run: | - sudo apt-get update - sudo apt-get -y install gnutls-dev libkeyutils-dev libnl-3-dev libnl-genl-3-dev libglib2.0-dev - - - name: Configure - run: | - ./autogen.sh - ./configure --with-systemd - - - name: Build - run: make - - - name: Check - run: make check - - - name: Distcheck - run: make distcheck + - uses: actions/checkout@v4 + + - name: Install dependencies + run: | + sudo apt-get update + sudo apt-get -y install \ + gnutls-dev \ + libkeyutils-dev \ + libnl-3-dev \ + libnl-genl-3-dev \ + libglib2.0-dev + + - name: Configure + run: | + ./autogen.sh + ./configure --with-systemd + + - name: Build + run: make + + - name: Check + run: make check + + - name: Distcheck + run: make distcheck From 9e665652a9fd2f912151a9fe4cef81f6c2bbc1b3 Mon Sep 17 00:00:00 2001 From: Chuck Lever Date: Thu, 14 Aug 2025 14:16:46 -0400 Subject: [PATCH 2/3] workflows: No need to build test on old ARM platforms Signed-off-by: Chuck Lever --- .github/workflows/makefile.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/makefile.yml b/.github/workflows/makefile.yml index 7a2ea4a..918d248 100644 --- a/.github/workflows/makefile.yml +++ b/.github/workflows/makefile.yml @@ -1,5 +1,5 @@ --- -name: Multi-platform CI +name: Build tests on: [push, pull_request, workflow_dispatch] @@ -13,8 +13,6 @@ jobs: matrix: platform: - linux/amd64 - - linux/arm/v6 - - linux/arm/v7 - linux/arm64 steps: From e580afb9c7832e2e82d0e2c8ee0d6739537349ea Mon Sep 17 00:00:00 2001 From: Chuck Lever Date: Thu, 14 Aug 2025 13:37:55 -0400 Subject: [PATCH 3/3] workflows: Add MUSL build test Address issue #92 by adding an Alpine container to the "makefile.yaml" workflow. Signed-off-by: Chuck Lever --- .github/workflows/makefile.yml | 44 +++++++++++++++++++++++++++++++++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/.github/workflows/makefile.yml b/.github/workflows/makefile.yml index 918d248..d665d79 100644 --- a/.github/workflows/makefile.yml +++ b/.github/workflows/makefile.yml @@ -4,7 +4,7 @@ name: Build tests on: [push, pull_request, workflow_dispatch] jobs: - build: + build-glibc: runs-on: ubuntu-latest permissions: read-all @@ -41,3 +41,45 @@ jobs: - name: Distcheck run: make distcheck + + build-musl: + + runs-on: ubuntu-latest + container: alpine:latest + strategy: + fail-fast: false + matrix: + platform: + - linux/amd64 + - linux/arm64 + + steps: + - uses: actions/checkout@v4 + + - name: Install dependencies + run: | + apk update + apk add --no-cache \ + build-base \ + autoconf \ + automake \ + libtool \ + gnutls-dev \ + keyutils-dev \ + libnl3-dev \ + glib-dev \ + linux-headers + + - name: Configure + run: | + ./autogen.sh + ./configure --with-systemd + + - name: Build + run: make + + - name: Check + run: make check + + - name: Distcheck + run: make distcheck