test: fix unit test case sensitivity #993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling filesystem specific case sensitivity, by creating temporary files and checking if they point towards same file using their inodes. This fixes oracle#992 Signed-off-by: Achraf Maghous <achraf.maghous@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
behnazh-w
changed the title
tromai
reviewed
Feb 17, 2025
tromai
reviewed
Feb 17, 2025
Using tmp_path made the use of st_ino obselete, now we create paths using touch method Signed-off-by: Achraf Maghous <achraf.maghous@oracle.com>
tromai
reviewed
Feb 17, 2025
Fixed checking case sensitivity using tmp_path, without needing to clean up created temporary files by using the existing tmp_path function argument already provided in test_get_local_artifact_paths_succeeded_pypi Signed-off-by: Achraf Maghous <achraf.maghous@oracle.com>
…ivity Using tempfile builtin package in order to check case sensitivity by observing the behavior of when creating lower and upper directory Signed-off-by: Achraf Maghous <achraf.maghous@oracle.com>
behnazh-w
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling filesystem specific case sensitivity, by creating temporary files and checking if they point towards same file using their inodes. This fixes #992