Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spellcheck tests #228

Open
wants to merge 2 commits into
base: master
from

Conversation

@KashifSaadat
Copy link
Contributor

commented Sep 28, 2018

Changes:

  • Added misspell library and extend tests to perform a spellcheck on golang and markdown files (vendor directory is excluded)
  • Updated docs where the spellcheck test detected typos.
@KashifSaadat

This comment has been minimized.

Copy link
Contributor Author

commented Sep 28, 2018

Kept the commits separate so they're easier to review.

@KashifSaadat KashifSaadat force-pushed the appvia:add-spellcheck branch 2 times, most recently from 3182df9 to 667191a Sep 28, 2018
@prydie

This comment has been minimized.

Copy link
Member

commented Oct 1, 2018

Thanks for the PR @KashifSaadat 😄!

Would you mind splitting it out into two separate PRs as the two changes are unrelated as far as I can see?

Additionally, we'll probably want to update the CI image to include a prebuilt misspell binary rather than go installing it every time. There's no automation set up for building the CI images so I'm happy to pick up that part of the change if you're happy with me doing so?

@KashifSaadat

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2018

Hey @prydie, sure that sounds good. I've raised PR #229 with the commit for the RBAC template updates. Shall we close this PR in favour of your CI image update?

@KashifSaadat KashifSaadat changed the title Add spellcheck tests and update RBAC template Add spellcheck tests Oct 4, 2018
@KashifSaadat KashifSaadat force-pushed the appvia:add-spellcheck branch from e359331 to df3e65a Oct 4, 2018
Signed-off-by: Kashif Saadat <kashifsaadat@gmail.com>
Signed-off-by: Kashif Saadat <kashifsaadat@gmail.com>
@KashifSaadat KashifSaadat force-pushed the appvia:add-spellcheck branch from df3e65a to 9d9147d Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.