This repository has been archived by the owner on Jun 23, 2020. It is now read-only.
Wait for AVAILABLE status before returning from create #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prydie
suggested changes
Aug 7, 2018
pkg/provisioner/block/block.go
Outdated
| metadata instancemeta.Interface, | ||
| volumeRoundingEnabled bool, | ||
| minVolumeSize resource.Quantity, | ||
| timeout time.Duration) plugin.ProvisionerPlugin { |
There was a problem hiding this comment.
func NewBlockProvisioner(client client.ProvisionerClient,
metadata instancemeta.Interface,
volumeRoundingEnabled bool,
minVolumeSize resource.Quantity,
timeout time.Duration,
) plugin.ProvisionerPlugin {
pkg/provisioner/block/block.go
Outdated
| return false, err | ||
| } | ||
|
|
||
| if getVolumeResponse.LifecycleState == core.VolumeLifecycleStateAvailable { |
There was a problem hiding this comment.
switch state := getVolumeResponse.LifecycleState {
case core.VolumeLifecycleStateAvailable:
return true, nil
case core.VolumeLifecycleStateFaulty, core.VolumeLifecycleStateTerminated, core.VolumeLifecycleStateTerminating:
return false, fmt.Errorf("volume has lifecycle state %q", state)
}
pkg/provisioner/block/block.go
Outdated
| return false, nil | ||
| } | ||
|
|
||
| ready, err := isVolumeReady() |
There was a problem hiding this comment.
return wait.PollImmediate(time.Second * 5, timeout, func() (bool, error) {
ready, err := isVolumeReady()
if err != nil {
return false, fmt.Errorf("failed to provision volume %q: %v", *volumeID, err)
}
return ready, nil
})k8s.io/apimachinery/pkg/util/wait
There was a problem hiding this comment.
I was halfway through writing this and then thought K8s would have something...
pkg/provisioner/block/block.go
Outdated
| ctx, cancel := context.WithTimeout(block.client.Context(), block.client.Timeout()) | ||
| defer cancel() | ||
|
|
||
| _, _ = block.client.BlockStorage().DeleteVolume(ctx, request) |
There was a problem hiding this comment.
_, _ = block.client.BlockStorage().DeleteVolume(ctx, core.DeleteVolumeRequest{
VolumeId: newVolume.Id,
})| @@ -102,8 +108,9 @@ func (p *mockProvisionerClient) TenancyOCID() string { | |||
| } | |||
|
|
|||
| // NewClientProvisioner creates an OCI client from the given configuration. | |||
| func NewClientProvisioner(pcData client.ProvisionerClient) client.ProvisionerClient { | |||
| return &mockProvisionerClient{} | |||
| func NewClientProvisioner(pcData client.ProvisionerClient, | |||
There was a problem hiding this comment.
Either
func NewClientProvisioner(pcData client.ProvisionerClient, storage *mockBlockStorageClient) client.ProvisionerClient {or
func NewClientProvisioner(
pcData client.ProvisionerClient,
storage *mockBlockStorageClient,
) client.ProvisionerClient {
prydie
approved these changes
Aug 7, 2018
rjtsdl
pushed a commit
to rjtsdl/oci-volume-provisioner
that referenced
this pull request
Dec 20, 2018
* Refactor LBSpec to derive state up-front * Fix panic when no backends * Refactor security list manager to use portSpec * Remove old node port rule in Update() * Remove old node port rule in securityListManger.Update() rather than
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.