Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit 292d09bdf breaks dpiDeqOptions_getWait and dpiMsgProps_getNumAttempts #16

Closed
CraZySacX opened this issue Jul 12, 2017 · 2 comments
Labels

Comments

@CraZySacX
Copy link

The changes to the dpiDeqOptions__getAttrValue function where the valueLength is checked for null cause the dpiDeqOptions_getWait call to always fail because the valueLength is hardcoded to NULL.

int dpiDeqOptions_getWait(dpiDeqOptions *options, uint32_t *value)
{
    return dpiDeqOptions__getAttrValue(options, DPI_OCI_ATTR_WAIT, __func__,
   value, NULL);
}

Similar case in dpiMsgProps

int dpiMsgProps_getNumAttempts(dpiMsgProps *props, int32_t *value)
{
    return dpiMsgProps__getAttrValue(props, DPI_OCI_ATTR_ATTEMPTS, __func__,
            value, NULL);
}

Those two fell out of my tests, but a quick glance at some other functions where a numeric is the out value have the same issue.

@anthony-tuininga
Copy link
Member

Oops. I'll get that corrected. Thanks for reporting it!

@anthony-tuininga
Copy link
Member

This has been corrected. I've added some test cases in the cx_Oracle test suite to ensure this problem doesn't turn up again. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants