New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SessionPool won't accept unicode #23

Closed
mechsin opened this Issue May 11, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@mechsin
Copy link

mechsin commented May 11, 2017

Python 2.7 32 bit
cx_Oracle 5.3
Oracle instant client 12.1
Windows 7 64 bit
VCForPython27 Compiler

I have a case where it appears that the cx_Oracle.connect method will accept the login credentials as unicode strings but the cx_Oracle.SessionPool will not.

I have check this simply by using the same login credentials with both functions.

In my test case the user name, password, and dsn are all unicode strings. The exception I get when calling the session pool is below.

sessionPool = cx_oracle.SessionPool(*r_pargs, **r_kwargs)
TypeError: argument 1 must be str, not unicode

I guess this isn't really a bug so much as inconsistent behavior if the connect method accepts Unicode strings I would expect the SessionPool to as well, at least for the fields that is has in common with connect.

@anthony-tuininga

This comment has been minimized.

Copy link
Member

anthony-tuininga commented May 14, 2017

I agree that is inconsistent behaviour. I'll adjust that. Thanks for pointing it out!

anthony-tuininga added a commit that referenced this issue Jun 10, 2017

@anthony-tuininga

This comment has been minimized.

Copy link
Member

anthony-tuininga commented Jun 10, 2017

Changes made. I also adjusted connection.changepassword() which was behaving the same way.

@mechsin

This comment has been minimized.

Copy link
Author

mechsin commented Jun 12, 2017

Great thanks.

Can you comment on when this will be released?

@anthony-tuininga

This comment has been minimized.

Copy link
Member

anthony-tuininga commented Jun 12, 2017

All I can say right now is soon. :-) It might be this week but it might be next week, too. It depends on what else is discovered in the next few days!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment