Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#raise without argument shouldn't have a message #1487

Closed
MaxLap opened this Issue Nov 29, 2018 · 2 comments

Comments

2 participants
@MaxLap
Copy link

MaxLap commented Nov 29, 2018

On MRI and JRuby:

raise rescue a = $!; a.message
 #=> ''

On truffleruby:

raise rescue a = $!; a.message
 #=> "No current exception"

My initial thought is that the message should just be removed here:

exc = RuntimeError.new('No current exception')

MaxLap added a commit to deep-cover/deep-cover that referenced this issue Nov 30, 2018

MaxLap added a commit to deep-cover/deep-cover that referenced this issue Nov 30, 2018

MaxLap added a commit to deep-cover/deep-cover that referenced this issue Dec 2, 2018

MaxLap added a commit to deep-cover/deep-cover that referenced this issue Dec 2, 2018

MaxLap added a commit to deep-cover/deep-cover that referenced this issue Dec 6, 2018

MaxLap added a commit to deep-cover/deep-cover that referenced this issue Dec 6, 2018

@nirvdrum nirvdrum self-assigned this Feb 1, 2019

@nirvdrum

This comment has been minimized.

Copy link
Member

nirvdrum commented Feb 1, 2019

Thanks for the bug report and for tracking down the problem! I'm sorry this one slipped through the cracks. I'll get a fix in shortly, but unfortunately it's going to miss the next release.

dougxc pushed a commit that referenced this issue Feb 4, 2019

Fix GH #1487: Remove the message from exceptions raised by bare `rais…
…e` to better match MRI.

PullRequest: truffleruby/584

@nirvdrum nirvdrum added this to the 1.0.0-rc13 milestone Feb 5, 2019

@nirvdrum

This comment has been minimized.

Copy link
Member

nirvdrum commented Feb 5, 2019

This was fixed by 648d728, but unfortunately I couldn't get the fix before 1.0.0 RC 12 was released. The fix will be available in the next release.

@nirvdrum nirvdrum closed this Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.