Skip to content

Conversation

@jshum2479
Copy link
Member

No description provided.

@jshum2479 jshum2479 requested a review from rakillen June 6, 2019 19:41
:param wallet_path: opss extracted wallet
:param password: opss store extraction time password
"""
_method_name = 'setSharedSecretStoreWithPassword'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't match method name set_shared_secret_store_with_password

rakillen
rakillen previously approved these changes Jun 6, 2019
Copy link
Contributor

@CarolynRountree CarolynRountree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. What about documentation
  2. Would you move the file related code in domain_creator to the FileUtils so it can be reused and also not embedded in domain_creator as single code stream.
  3. What about the counterpart in discover?

@jshum2479
Copy link
Member Author

@CarolynRountree @ddsharpe

  1. Should this be documented and where
  2. I am trying a place to move the common python code.
  3. There is no discovery for now.

@jshum2479 jshum2479 merged commit 02bd732 into master Jun 7, 2019
@jshum2479 jshum2479 deleted the addopssencryptkey branch June 7, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants