Added test to update DataSource info via Common Mount #2441
Conversation
marinakog
requested review from
anpanigr,
bhavaniravichandran,
vanajamukkara and
xiancao
|
|
||
| logger.info("Creating unique namespace for Domain2"); | ||
| assertNotNull(namespaces.get(2), "Namespace list is null"); | ||
| domain2Namespace = namespaces.get(2); |
There was a problem hiding this comment.
Why we need 2 domains in this usecases ? If needed please explain on the javadoc section of the test method.
There was a problem hiding this comment.
just to make the tests independent from each other.
There was a problem hiding this comment.
I would rather prefer merge the usecase to avoid multiple domain boot if possible, you can make the Data Source uecase as additional common mount in addition to the existing test method.
There was a problem hiding this comment.
changed test to have 1 domain
| domain2Uid, miiCMImage3, domain2Namespace); | ||
| createDomainAndVerify(domain2Uid, domainCR, domain2Namespace, | ||
| adminServerPodName, managedServerPrefix, replicaCount); | ||
| podsWithTimeStamps = getPodsWithTimeStamps(adminServerPodName, |
There was a problem hiding this comment.
you can move this into patchDomainWithCMImageAndVerify method as that's where its used
| + " in the new patched domain"); | ||
|
|
||
| //get current timestamp before domain rolling restart to verify domain roll events | ||
| OffsetDateTime timestamp = now(); |
There was a problem hiding this comment.
not used, you can remove it
| String.format("Rolling restart failed for domain %s in namespace %s", domainUid, domainNamespace)); | ||
| } | ||
|
|
||
| private Map getPodsWithTimeStamps(String adminServerPodName, String managedServerPrefix, |
There was a problem hiding this comment.
have you checked if there are any utility methods? we may be doing this in multiple tests
There was a problem hiding this comment.
switched to common util
| int adminServiceNodePort | ||
| = getServiceNodePort(domain2Namespace, getExternalServicePodName(adminServerPodName), "default"); | ||
| assertNotEquals(-1, adminServiceNodePort, "admin server default node port is not valid"); | ||
| assertTrue(checkDS(adminServerPodName,domain2Namespace, |
There was a problem hiding this comment.
can you check the methods in CommonTestUtils if you can use them - checkSystemResourceConfig and others?
There was a problem hiding this comment.
switched to common util
4 participants
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5567/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5568/