-
Notifications
You must be signed in to change notification settings - Fork 216
Modify new image used by testUpdateImageName of ItIntrospectVersion #2446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * e.g, "image:container-registry.oracle.com/middleware/weblogic:2021-07-08-162571383699" | ||
| * Verify all the pods are restarted and back to ready state | ||
| * Verify the admin server is accessible and cluster members are healthy | ||
| * This test will be skipped if the image tag is the latest WebLogic image tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need not skip the test if the tag is latest i.e. 14.1.1.0-x, since we are tagging the same image to an image with a time stamp appended. Modify the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't skip the test if the tag being input from Jenkins run is 14.1.1.0-x since
String imageUpdate = KIND_REPO != null ? KIND_REPO
+ (WEBLOGIC_IMAGE_NAME + ":" + imageTag).substring(TestConstants.BASE_IMAGES_REPO.length() + 1)
: WEBLOGIC_IMAGE_NAME + ":" + imageTag;
So it all depends on WEBLOGIC_IMAGE_NAME.
I'm going to modify the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run it against the OKE cluster as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maggiehe00 please coordinate with Marina to run the tests on OKE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already kicked off a run as @sankarpn suggested
"Please run this IT class against the OKE cluster in job https://build.weblogick8s.org:8443/job/wko-oke-nightly-seqential/".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just aborted it after talking to Marina.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anpanigr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sankarpn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run this IT class against the OKE cluster in job https://build.weblogick8s.org:8443/job/wko-oke-nightly-seqential/
sankarpn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
From wko-pipeline meeting, "Do we need to verify WLS images which is not passed as parameter in Jenkin e.g. 14.1.1.0-11 even if the IMAGE TAG is 12.2.1.4.0".
Modify the new image name to address the issue.
Jenkins full suite:
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5591/testReport/
Single test class:
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5588/testReport/
OKE test passed at
https://build.weblogick8s.org:8443/job/wko-oke-nightly-seqential/338/testReport/