Integration Test: Add error path testing for Auxiliary Image feature #2457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anpanigr
reviewed
Jul 14, 2021
integration-tests/src/test/java/oracle/weblogic/kubernetes/utils/CommonMiiTestUtils.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiAuxiliaryImage.java
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiAuxiliaryImage.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiAuxiliaryImage.java
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiAuxiliaryImage.java
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiAuxiliaryImage.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiAuxiliaryImage.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiAuxiliaryImage.java
Show resolved
Hide resolved
vanajamukkara
suggested changes
Jul 15, 2021
Contributor
vanajamukkara
left a comment
vanajamukkara
left a comment
There was a problem hiding this comment.
Can you add a check that domain is not restarted for all the negative cases?
anpanigr
reviewed
Jul 15, 2021
|
|
||
| // verify the domain is not rolled | ||
| // TODO: enable this check once https://jira.oraclecorp.com/jira/browse/OWLS-90971 is fixed | ||
| /* |
Member
There was a problem hiding this comment.
Do we need to sleep if we are using utility oracle.weblogic.kubernetes.utils.CommonMiiTestUtils.verifyPodsNotRolled;
Contributor
Author
There was a problem hiding this comment.
yes, in the oracle.weblogic.kubernetes.utils.CommonMiiTestUtils.verifyPodsNotRolled, it only sleeps for 2 minutes. It is not enough in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following negative tests case for auxiliary image feature. Make sure errors are reported clearly.
(a) Missing common directory common mount path is not in the image
(b) missing domain config, what happens if the common mount contains only sparse JMS config
(c) common mount with out WDT binary
(d) Test a domain resource configuration using a custom common mount command that's guaranteed to fail, for example: exit 1.
https://build.weblogick8s.org:8443/view/all/job/weblogic-kubernetes-operator-kind-new/5643/
https://build.weblogick8s.org:8443/view/all/job/weblogic-kubernetes-operator-kind-new/5640/
https://build.weblogick8s.org:8443/view/all/job/weblogic-kubernetes-operator-kind-new/5644/