Refactor TwoDomainLoadBalancer class for separate LoadBalancers #2731
Conversation
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItLBApache.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItLBApache.java
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItLBApache.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItLBApache.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItLBNginx.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItLBNginx.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItLBNginx.java
Outdated
Show resolved
Hide resolved
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
| import static org.junit.jupiter.api.Assumptions.assumeFalse; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Modify the description specific to Traefik LoadBalancer.
There was a problem hiding this comment.
Test a single operator can manage multiple WebLogic domains with as single Traefik fronted loadbalancer -->
Test a single operator can manage multiple WebLogic domains with a single Traefik fronted loadbalancer
integration-tests/src/test/java/oracle/weblogic/kubernetes/ItLBTraefik.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Agree with @anpanigr right now we don't run external LB on OKD so no corresponding OKD code are needed in It(LB) test classes.
anpanigr
left a comment
anpanigr
left a comment
There was a problem hiding this comment.
Can u add a - before the index in domain id as follow ...
domainUids.add("wls-nginx-domain" + i); to domainUids.add("wls-nginx-domain-" + i);
domainUids.add("wls-apache-domain" + i); to domainUids.add("wls-apache-domain-" + i);
domainUids.add("wls-traefik-domain" + i); to domainUids.add("wls-traefik-domain-" + i);
for better visibility during triaging
anpanigr
left a comment
anpanigr
left a comment
There was a problem hiding this comment.
Modify the script and pom files which refers to ItTwoDomainsLoadBalancers
I found one file oketest.sh
fixed |
fixed |
…arate LoadBalancers (#2731) * wip * re-org loadbalancer tests * re-org loadbalancer tests * fix expected error msg * fix copyright * address Pani and Maggies's comments * address Pani's comments * address Pani's comments
4 participants
Currently TwoDomainLoadBalancer class has all the LoadBalancer usecase in one class and the Test methods has unnecessary dependencies on each other. In order to avoid dependency,
Create separate class for each LB. Move the Test(1) and Test(2) to a separate class. For each LoadBalancer class beforeAll() create two domains and install the LoadBalancer, then all tests are independent.
Jenkins job:
https://build.weblogick8s.org:8443/view/all/job/weblogic-kubernetes-operator-kind-new/8200/
https://build.weblogick8s.org:8443/view/all/job/weblogic-kubernetes-operator-kind-new/8201/