Skip to content

owls-99865 - Issue 3133 - Report helpful error when domainUID starts with number #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 22, 2022
Merged

owls-99865 - Issue 3133 - Report helpful error when domainUID starts with number #3195

merged 6 commits into from
Jun 22, 2022

Conversation

@alai8
Copy link
Member

@alai8 alai8 commented Jun 21, 2022

Add validation to ensure that domainUID value provided to create-domain.sh script in samples is a valid WebLogic domain nam

resolves #3133

https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/11041/

@alai8 alai8 requested review from doxiao and rjeberhard June 21, 2022 17:40
doxiao
doxiao approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@doxiao doxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjeberhard
Copy link
Member

rjeberhard commented Jun 22, 2022

@alai8, looks like this is causing a bunch of test failures... Can you please check?

@alai8
Copy link
Member Author

alai8 commented Jun 22, 2022

@alai8, looks like this is causing a bunch of test failures... Can you please check?

The 3 failures at https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/11041/

oracle.weblogic.kubernetes.ItLiftAndShiftFromOnPremDomain.testCreateMiiDomainWithClusterFromOnPremDomain
oracle.weblogic.kubernetes.ItFmwSample.testFmwDomainInPv(String)[1]
oracle.weblogic.kubernetes.ItMiiDynamicUpdatePart1.testMiiRemoveTarget

are the same as ones listed under Main Kind Nightly (parallel) for 6/22 on the Operator Integration Test Nightly Triage page

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rjeberhard rjeberhard merged commit 29f0a2e into main Jun 22, 2022
@rjeberhard rjeberhard deleted the owls99865 branch June 22, 2022 20:30
@alai8 alai8 mentioned this pull request Jun 23, 2022
Merged
rjeberhard pushed a commit to rjeberhard/weblogic-kubernetes-operator that referenced this pull request Apr 14, 2023
@alai8
owls-99865 - Issue 3133 - Report helpful error when domainUID starts …
801bf97 
…with number (oracle#3195)

* add validation that domainUID argument must be a valid WebLogic domain name
robertpatrick pushed a commit that referenced this pull request Apr 26, 2023
@alai8
owls-99865 - Issue 3133 - Report helpful error when domainUID starts …
84e546f 
…with number (#3195)

* add validation that domainUID argument must be a valid WebLogic domain name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjeberhard rjeberhard rjeberhard approved these changes

+1 more reviewer

@doxiao doxiao doxiao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Domain names starting with numbers: output helpful error message

3 participants

@alai8 @rjeberhard @doxiao