Add -fnested-functions to tests_CFLAGS #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some versions of GCC (e.g., Xcode's GCC on OS X), the -fnested-functions flag needs to be passed as nested functions are disabled by default. This fixes test compilation errors on OS X when using GCC 4.2.1. Signed-off-by: Eddie Ringle <eddie@eringle.net>
orangeduck
added a commit
that referenced
this pull request
May 18, 2013
…-tests Add -fnested-functions to tests_CFLAGS
|
This breaks the install on my machine (64-bit Ubuntu on DigitalOcean) $ make check
Making check in src
make[1]: Entering directory `/home/jpm/libCello/src'
make[1]: Nothing to be done for `check'.
make[1]: Leaving directory `/home/jpm/libCello/src'
Making check in tests
make[1]: Entering directory `/home/jpm/libCello/tests'
make tests
make[2]: Entering directory `/home/jpm/libCello/tests'
gcc -DHAVE_CONFIG_H -I. -I.. -I../tests -std=gnu99 -Wall -Werror -Wextra -Wno-unused -fnested-functions -g -O2 -MT tests-core.o -MD -MP -MF .deps/tests-core.Tpo -c -o tests-core.o `test -f 'core.c' || echo './'`core.c
cc1: error: unrecognized command line option â-fnested-functionsâ
make[2]: *** [tests-core.o] Error 1
make[2]: Leaving directory `/home/jpm/libCello/tests'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/home/jpm/libCello/tests'
make: *** [check-recursive] Error 1
$ gcc --version
gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
Copyright (C) 2011 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
|
|
All tests pass when i remove -fnested-functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some versions of GCC (e.g., Xcode's GCC on OS X), the -fnested-functions
flag needs to be passed as nested functions are disabled by default.
This fixes test compilation errors on OS X when using GCC 4.2.1.
Signed-off-by: Eddie Ringle eddie@eringle.net