Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check fails on master #64

Closed
igalic opened this issue Nov 7, 2013 · 7 comments
Closed

make check fails on master #64

igalic opened this issue Nov 7, 2013 · 7 comments

Comments

@igalic
Copy link

igalic commented Nov 7, 2013

igalic@levix ~/src/libCello (git)-[master] % make CC=gcc check
gcc tests/core.c -c -I ./include -std=gnu99 -Wall -Werror -Wno-unused -O3 -g -fPIC -o obj/core.o
gcc tests/data.c -c -I ./include -std=gnu99 -Wall -Werror -Wno-unused -O3 -g -fPIC -o obj/data.o
gcc tests/exceptions.c -c -I ./include -std=gnu99 -Wall -Werror -Wno-unused -O3 -g -fPIC -o obj/exceptions.o
gcc tests/functional.c -c -I ./include -std=gnu99 -Wall -Werror -Wno-unused -O3 -g -fPIC -o obj/functional.o
gcc tests/memory.c -c -I ./include -std=gnu99 -Wall -Werror -Wno-unused -O3 -g -fPIC -o obj/memory.o
gcc tests/ptest.c -c -I ./include -std=gnu99 -Wall -Werror -Wno-unused -O3 -g -fPIC -o obj/ptest.o
gcc tests/test.c -c -I ./include -std=gnu99 -Wall -Werror -Wno-unused -O3 -g -fPIC -o obj/test.o
gcc tests/threading.c -c -I ./include -std=gnu99 -Wall -Werror -Wno-unused -O3 -g -fPIC -o obj/threading.o
gcc obj/core.o obj/data.o obj/exceptions.o obj/functional.o obj/memory.o obj/ptest.o obj/test.o obj/threading.o libCello.a -lpthread -ldl -lm -o test
./test

    +-------------------------------------------+
    | ptest          MicroTesting Magic for C   |
    |                                           |
    | Daniel Holden (contact@theorangeduck.com) |
    +-------------------------------------------+


  ===== Suite Core =====

    | Test Type ... Passed! 
    | Test Cast ... Passed! 
    | Test New ... Passed! 
    | Test Assign ... Passed! 
    | Test Copy ... Passed! 
    | Test Eq ... Passed! 
    | Test Ord ... Passed! 
    | Test Hash ... Passed! 
    | Test Collection ... Passed! 
    | Test Iter ... Passed! 
    | Test Push ... Passed! 
    | Test At ... Passed! 
    | Test Dict ... Passed! 
    | Test As Ctype ... Passed! 
    | Test Stream ... Passed! 
    | Test Type New ... Passed! 
    | Test Type Implements ... Passed! 
    | Test Type Parent ... Failed! 

        1. Segmentation Fault

    | Stopping Execution.
igalic@levix ~/src/libCello (git)-[master] % 

unfortunately, I can't find a core-file, so I can't tell why it's failing

@orangeduck
Copy link
Owner

Hey,

What compiler and operating system are you using?

Thanks

@igalic
Copy link
Author

igalic commented Nov 7, 2013

Hi,

gcc is in version 4.8.1. Clang 3.4 also fails, see #65

@whatot
Copy link

whatot commented Nov 7, 2013

Clang may be the default compiler.
You can try make CC=gcc; make check CC=gcc, there willn't be error.
And if you try make CC=clang; make check CC=gcc, there willn't be error.
So the point is clang didn't support the macros in ptest.

@igalic
Copy link
Author

igalic commented Nov 8, 2013

@whatot I have updated the issue description to be unambiguous, and have added a #65 to track the clang failure seperately.

@orangeduck
Copy link
Owner

Thanks I'll try and take a look into it this weekend.

@orangeduck
Copy link
Owner

Hopefully this is fixed in 138d6e0. Some code that was not adhering to the standard got broken under the new compiler version.

@igalic
Copy link
Author

igalic commented Nov 10, 2013

Thanks! Works now!

@igalic igalic closed this as completed Nov 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants