Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OHRM-351: sendmail configuration change #528

Merged
merged 2 commits into from Jun 14, 2019

Conversation

@Damith88
Copy link
Contributor

@Damith88 Damith88 commented Jun 13, 2019

No description provided.

@@ -48,7 +59,7 @@ public function configure() {
'sendmail' => 'Sendmail',
'smtp' => 'SMTP')
)),
'txtSendmailPath' => new sfWidgetFormInputText(),
'txtSendmailPath' => new sfWidgetFormInputText([], ['disabled' => 'disabled']),
Copy link
Member

@samanthajayasinghe samanthajayasinghe Jun 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to keep it as disabled input field? can we show it as a label.

Loading

Copy link
Contributor Author

@Damith88 Damith88 Jun 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is done.

Loading

@@ -512,7 +512,8 @@ INSERT INTO `hs_hr_config`(`key`, `value`) VALUES ('ldap_server', ''),
('leave.include_pending_leave_in_balance', 1),
('admin.default_workshift_start_time', '09:00'),
('admin.default_workshift_end_time', '17:00'),
('report.mysql_group_concat_max_len', 2048);
('report.mysql_group_concat_max_len', 2048),
('email_config.sendmail_path', '/usr/sbin/sendmail -bs');
Copy link
Member

@samanthajayasinghe samanthajayasinghe Jun 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a same path for all linux distribution? I mean ubuntu, centos redhat

Loading

Copy link
Contributor Author

@Damith88 Damith88 Jun 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't find more information about this.

Loading

@samanthajayasinghe samanthajayasinghe merged commit cfd5601 into orangehrm:4.3.2 Jun 14, 2019
1 check passed
Loading
Kaveesha-Silva-OrangeHRM added a commit to Kaveesha-Silva-OrangeHRM/orangehrm that referenced this issue Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants