01 - Weight changer

[0xSpraggins]

No description provided.

[gerrrg]

I'm going to make some additional edits to the factory here that I did not leave comments for. I'll tag you when those are done

[gerrrg]

mostly tweaks

[gerrrg]

Can you add a line to the top level README following the example from NullController?

[0xSpraggins]

Can you add a line to the top level README following the example from NullController?

Im pretty sure its already like the NullController. But correct me if Im wrong https://github.com/orbcollective/mpc-examples/blob/weight_changer/pkg/mpc-examples/contracts/01-weight-changer/README.md?plain=1#L1

[gerrrg]

Overall seems reasonable to me. Added one comment in-line.

One additional note: in the constructor, we have a call to make sure the poolId and Vault are legit, but then in the next line of code, we're going vault.getPoolTokens(poolId) which would also satisfy that check. Do we want to eliminate that redundancy, or keep it for the sake of uniformity among these example controllers?

[0xSpraggins]

Overall seems reasonable to me. Added one comment in-line.

One additional note: in the constructor, we have a call to make sure the poolId and Vault are legit, but then in the next line of code, we're going vault.getPoolTokens(poolId) which would also satisfy that check. Do we want to eliminate that redundancy, or keep it for the sake of uniformity among these example controllers?

I vote to remove it.

[gerrrg]

tiny edit