Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: Ability to copy/paste grids and sections #2437

Closed
ebruchez opened this issue Nov 17, 2015 · 5 comments
Closed

RFE: Ability to copy/paste grids and sections #2437

ebruchez opened this issue Nov 17, 2015 · 5 comments
Assignees
@ebruchez
Labels
Missing Tests Module: Form Builder Type: RFE
Projects
Orbeon Forms 2017.2
Milestone
2017.2

Comments

@ebruchez
Copy link
Collaborator

+1 from customer
@ebruchez ebruchez changed the title RFE: Ability to copy/paste grid/sections or just grid/section settings RFE: Ability to copy/paste grid and sections Nov 21, 2015
@ebruchez ebruchez changed the title RFE: Ability to copy/paste grid and sections RFE: Ability to copy/paste grids and sections Nov 21, 2015
@ebruchez
Copy link
Collaborator Author

ebruchez commented May 5, 2017

+1 from evaluator

@ebruchez ebruchez mentioned this issue May 18, 2017
Closed
@ebruchez
Copy link
Collaborator Author

ebruchez commented May 18, 2017 •
edited

  • on the sections and grids (including non-repeated grids)
    • add cut and copy icons
      • no bootstrap 2 icons for cut/copy
    • "cut" must follow same rule as "remove": can't remove last from container, in particular
    • copy data, binds, repeat templates, resources, controls to the clipboard
      • There is probably no need to do anything with actions and services for now. The cut/copy item will be pasted back into the same form definition. It is possible that an action target is missing upon cut, but that's the case even if you cut a single control.
      • repeat templates: check if copy OR regenerate
  • if cutting grid in repeated section, handle multiple series of data holders
  • paste: need to make sure to avoid id/name conflicts (see also "Merge" or "copy" option for section templates #3195)
    • remove/add tmp-*-tmp annotations
    • handle validation-*-validation
  • BUG: paste must handle repeat templates
    • right now, cut/paste of repeated grid removes template!
  • BUG: marking section as repeated no longer works
  • BUG: cut/paste section containing a repeated grid fails with error
  • Fix annotate.xpl test
  • Id generator must avoid ids/names in the clipboard as well, so if user cuts, then adds controls, conflicts are avoided.
  • BUG: got crash while pasting multiple-level nested sections
    • not sure if still reproducible
  • BUG: crash while cut/paste of empty non-repeated grid
  • when pasting non-repeated grids, must insert holders and resources at the best position, even if inserting after another non-repeated grid
    • → CHECK: Should be fixed now as non-repeated grids have ids.section
  • To avoid conflicts in control names: ask user to provide an optional prefix for controls.
    • basic function
    • BUG: With large section, cut/paste shows dialog with one conflict
      • haven't seen this since updating the code to find used names
  • tests
    • cut section/grid/repeated grid and paste somewhere else
    • copy section/grid/repeated grid and paste somewhere else
    • cut/copy section/grid/repeated grid within repeated section and paste in other repeated grid-
  • doc
  • P2: how to show that clipboard contains something? See comment below.
  • P2: Related: Add possibility to copy/paste between forms (Ability to copy/paste between forms #1839).

@ebruchez ebruchez self-assigned this Oct 4, 2017
@ebruchez
Copy link
Collaborator Author

ebruchez commented Oct 5, 2017

What could we do to make the clipboard and cut/copy/paste icons for the controls better?

  • it'd be nice to show what's in the clipboard: control/grid/section name, for example
  • make it clear that there is something in the clipboard
    • now we gray the icon if the clipboard is empty
  • maybe: show icon of item in clipboard
    • control icon
    • or section/grid/repeated grid icon

@ebruchez
Copy link
Collaborator Author

ebruchez commented Oct 6, 2017 •
edited

See #3348 for handling of repeats. For now, we only keep the values from the first iteration.

@ebruchez ebruchez mentioned this issue Oct 6, 2017
Open
ebruchez added a commit that referenced this issue Oct 10, 2017
@ebruchez
For #2437: cut/copy of sections/grids
2ec685d 
- add cut/copy icons to section/grid icons
- move icons to font-awesome
- move Form Settings/Edit Source to toolbox
- rename some functions for consistency
ebruchez added a commit that referenced this issue Oct 10, 2017
@ebruchez
For #2437: cut/paste of non-repeated grids
ca278bb 
- handle special case
- some renaming for clarity
- add return types
ebruchez added a commit that referenced this issue Oct 10, 2017
@ebruchez
For #2437: first version of multiple paste
f142b05 
- rename conflicting names and ids
ebruchez added a commit that referenced this issue Oct 10, 2017
@ebruchez
For #2437: fixes and refactoring
f4f95af 
- rename nested grids/sections
- insert repeat templates
- start passing implicit context
- `XPath`-ending function names for some functions called from XForms
ebruchez added a commit that referenced this issue Oct 10, 2017
@ebruchez
For #2437: fix test
7e3c17e
ebruchez added a commit that referenced this issue Oct 10, 2017
@ebruchez
For #2437: fix regression
045928f 
- was due to mixup between xf:instance and fb:instance
ebruchez added a commit that referenced this issue Oct 10, 2017
@ebruchez
For #2437: fix new grids/cells annotation
202a4d1
ebruchez added a commit that referenced this issue Oct 10, 2017
@ebruchez
For #2437: don't remove last grid row
36da739
ebruchez added a commit that referenced this issue Oct 10, 2017
@ebruchez
For #2437: fix regression with showing Control Settings dialog
fffc7bf
ebruchez added a commit that referenced this issue Oct 12, 2017
@ebruchez
For #3349 and #2437: fixes and improvements
dd99f4b 
- fix uses of `formInstanceRoot`
- improvements to Form Builder context
- cut/copy/paste
  - index instance
  - search for ids in xcv instance
@ebruchez ebruchez added this to the 2017.2 milestone Oct 13, 2017
@ebruchez ebruchez added this to In Progress in Orbeon Forms 2017.2 Oct 16, 2017
ebruchez added a commit that referenced this issue Oct 25, 2017
@ebruchez
For #2437: dialog to prefix/suffix control names
4412312
ebruchez added a commit that referenced this issue Oct 25, 2017
@ebruchez
For #2437: fix handling of names in use
d5fcf28 
- more correct way of identifying names in use
- handle `tmp` ids separately
- non-repeated grids without id get a permanent grid id
ebruchez added a commit that referenced this issue Oct 25, 2017
@ebruchez
For #2437: handle validation- ids
032b811
ebruchez added a commit that referenced this issue Oct 25, 2017
@ebruchez
For #2437: bug-fixes
43213a3
ebruchez added a commit that referenced this issue Oct 30, 2017
@ebruchez
For #2437: fix function
a99019a
@ebruchez ebruchez moved this from In Progress to Missing Doc in Orbeon Forms 2017.2 Oct 31, 2017
ebruchez added a commit that referenced this issue Oct 31, 2017
@ebruchez
For #2437 and others: consistently insert grid/section suffixes
438296a
ebruchez added a commit that referenced this issue Oct 31, 2017
@ebruchez
For #2437: tests
6349e55
@ebruchez
Copy link
Collaborator Author

Documented

@ebruchez ebruchez moved this from Missing Doc to Done in Orbeon Forms 2017.2 Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebruchez ebruchez

Labels
Missing Tests Module: Form Builder Type: RFE
Projects
No open projects
Orbeon Forms 2017.2
Done
Milestone
2017.2
Development

No branches or pull requests
1 participant
@ebruchez