New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF: fr:fields-date not readonly when service is called upon xforms-enabled #3113

Closed
ebruchez opened this Issue Feb 9, 2017 · 2 comments

Comments

Projects
1 participant
@ebruchez
Collaborator

ebruchez commented Feb 9, 2017

The component doesn't see its binding a readonly. This is because the following happens:

  • service called upon xforms-enabled for a control
  • service response causes insert
  • insert calls updateRepeatNodesets
  • following #2473, this does a rebuild
  • this causes node state to be cleared
  • soon after, xforms-enabled for the XBL control is dispatched
  • control now checks whether it's bound node is readonly
  • result is false as there hasn't been any recalculate/revalidate since

Regressed in 2016.1 with #2473 and b1c084f.

+1 from customer

@ebruchez ebruchez added this to the 2017.1 milestone Feb 9, 2017

@ebruchez ebruchez self-assigned this Feb 9, 2017

@ebruchez

This comment has been minimized.

Show comment
Hide comment
@ebruchez

ebruchez Feb 9, 2017

Collaborator

Ideas:

  1. don't only do rebuild but also recalculate/revalidate
    • this might be costly as it would be done for each insert
  2. also what about a function to directly get whether a control is readonly?
    • we already have xxf:is-control-relevant
    • entered #3114
  3. consider #2474
Collaborator

ebruchez commented Feb 9, 2017

Ideas:

  1. don't only do rebuild but also recalculate/revalidate
    • this might be costly as it would be done for each insert
  2. also what about a function to directly get whether a control is readonly?
    • we already have xxf:is-control-relevant
    • entered #3114
  3. consider #2474
@ebruchez

This comment has been minimized.

Show comment
Hide comment
@ebruchez

ebruchez Feb 9, 2017

Collaborator

Starting with idea 1.

Collaborator

ebruchez commented Feb 9, 2017

Starting with idea 1.

ebruchez added a commit that referenced this issue Feb 9, 2017

Fix #3113 "PDF: fr:fields-date not readonly when service is called up…
…on xforms-enabled"

- do `recalculate`/`revalidate`
- also do a single RRR per `insert` event

@ebruchez ebruchez closed this in 44a3b06 Feb 9, 2017

ebruchez added a commit that referenced this issue Feb 9, 2017

ebruchez added a commit that referenced this issue Feb 9, 2017

@ebruchez ebruchez added Missing Tests and removed Missing Tests labels Feb 9, 2017

ebruchez added a commit that referenced this issue Feb 9, 2017

ebruchez added a commit that referenced this issue Feb 9, 2017

ebruchez added a commit that referenced this issue Feb 9, 2017

@ebruchez ebruchez added this to Done in Orbeon Forms 2017.1 Apr 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment