New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit validation: issue with incremental character counter #3164

Closed
ebruchez opened this Issue Apr 10, 2017 · 1 comment

Comments

Projects
1 participant
@ebruchez
Collaborator

ebruchez commented Apr 10, 2017

@ebruchez ebruchez added this to the 2017.1 milestone Apr 10, 2017

@ebruchez ebruchez self-assigned this Apr 10, 2017

@ebruchez

This comment has been minimized.

Show comment
Hide comment
@ebruchez

ebruchez Apr 11, 2017

Collaborator

We didn't ensure that cloneInitialStateIfNeeded() was done. So if there were no incoming changes which would cause cloneInitialStateIfNeeded(), thing things would break. This was the case with the incremental character counter field: the value change happens incrementally, separately from the "Review" button action.

Collaborator

ebruchez commented Apr 11, 2017

We didn't ensure that cloneInitialStateIfNeeded() was done. So if there were no incoming changes which would cause cloneInitialStateIfNeeded(), thing things would break. This was the case with the incremental character counter field: the value change happens incrementally, separately from the "Review" button action.

@ebruchez ebruchez closed this in 4274139 Apr 11, 2017

ebruchez added a commit that referenced this issue Apr 11, 2017

Fix #3164 "Explicit validation: issue with incremental character coun…
…ter"

Conflicts:
	src/main/scala/org/orbeon/oxf/xforms/control/XFormsSingleNodeControl.scala

@ebruchez ebruchez added this to Done in Orbeon Forms 2017.1 Apr 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment