New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values in repeated grid are not shown on the summary page #3174

Closed
avernet opened this Issue Apr 21, 2017 · 2 comments

Comments

Projects
2 participants
@avernet
Collaborator

avernet commented Apr 21, 2017

To reproduce, in Form Builder create a form with a repeated grid containing a text field, mark the field as shown on the summary page, open the /new page for the form, add a couple of iterations, enter views, save, load the /summary page for the form, and notice that the values are not shown in the relevant column.

+1 from customer

@avernet avernet added the Form Runner label Apr 21, 2017

@avernet avernet added this to the 2017.1 milestone Apr 21, 2017

@avernet avernet self-assigned this Apr 21, 2017

@ebruchez ebruchez assigned ebruchez and unassigned avernet Apr 24, 2017

@ebruchez

This comment has been minimized.

Show comment
Hide comment
@ebruchez

ebruchez Apr 25, 2017

Collaborator

The issue is, as @avernet found out, that one path has parentheses around path elements, while the other one doesn't, in FormDefinition.findIndexedControls.

Collaborator

ebruchez commented Apr 25, 2017

The issue is, as @avernet found out, that one path has parentheses around path elements, while the other one doesn't, in FormDefinition.findIndexedControls.

@ebruchez ebruchez closed this in 2856653 Apr 26, 2017

ebruchez added a commit that referenced this issue Apr 26, 2017

Fix #3174 "Values in repeated grid are not shown on the summary page"
- also create datatypes for clarity
- no longer generate enclosing parentheses anymore for migration paths
- but still support them in existing migrations
- require that paths use only simple child element names
- add test
- migrate tests to ScalaTest

Conflicts:
	form-runner/src/main/scala/org/orbeon/oxf/fr/persistence/relational/index/FormDefinition.scala
@ebruchez

This comment has been minimized.

Show comment
Hide comment
@ebruchez

ebruchez Apr 26, 2017

Collaborator

Backported to 2016.3 branch as well.

Collaborator

ebruchez commented Apr 26, 2017

Backported to 2016.3 branch as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment