New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review use of HTML elements in ControlLabelHintTextEditor #3409

Closed
ebruchez opened this Issue Dec 19, 2017 · 2 comments

Comments

Projects
2 participants
@ebruchez
Collaborator

ebruchez commented Dec 19, 2017

This code can definitely not work as the grids use <div>s:

resourceEditorCurrentLabelHint =
    if (repeat.is("*"))
      repeat.find(
        "thead tr th:nth-child(" +
          (container.index() + 1) +
          ") .xforms-label, tbody tr td:nth-child(" +
          (container.index() + 1) +
          ") .xforms-text .xforms-output-output")
    else
      container.find(".xforms-label, .xforms-text .xforms-output-output").first()

Following #2738.

@avernet

This comment has been minimized.

Collaborator

avernet commented Mar 2, 2018

This is now in ControlLabelHintTextEditor.scala, runs when a new control was added attempting to find the label, so we can right away open the editor. And indeed, this isn't working anymore when the control is added to a repeated grid. This issue was already present in 2017.2.

@avernet avernet added this to Done in Orbeon Forms 2018.1 via automation Mar 2, 2018

@avernet avernet closed this in 33bbd22 Mar 2, 2018

@avernet avernet added this to To do in Orbeon Forms 2017.2.1 via automation Mar 2, 2018

@avernet

This comment has been minimized.

Collaborator

avernet commented Mar 2, 2018

Also cherry-picked for 2017.2-pe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment