New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard page number doesn't show if first page is subsection #3433

Closed
ebruchez opened this Issue Dec 30, 2017 · 5 comments

Comments

Projects
1 participant
@ebruchez
Collaborator

ebruchez commented Dec 30, 2017

<property
    as="xs:boolean"
    name="oxf.xforms.xbl.fr.wizard.subsections-nav.wizard.*"
    value="true"/>

screen shot 2017-12-29 at 8 06 02 pm

@ebruchez ebruchez self-assigned this Dec 30, 2017

@ebruchez ebruchez added this to the 2017.2.1 milestone Dec 30, 2017

@ebruchez ebruchez added this to To do in Orbeon Forms 2017.2.1 Jan 8, 2018

@ebruchez ebruchez removed this from the 2017.2.1 milestone Jan 8, 2018

@ebruchez ebruchez moved this from To do to To Review in Orbeon Forms 2017.2.1 Jan 31, 2018

@ebruchez ebruchez moved this from To Review to In progress in Orbeon Forms 2017.2.1 Mar 13, 2018

@ebruchez

This comment has been minimized.

Collaborator

ebruchez commented Mar 13, 2018

With this form:

  • $relevant-nav-case-ids: grid-1-grid-case,section-1.1-section-case,section-1.2-section-case,grid-2-grid-case,section-2.1-section-case,section-2.2-section-case
  • $current-nav-case-id: section-1-section-case

So $nav-case-index returns blank.

@ebruchez

This comment has been minimized.

Collaborator

ebruchez commented Mar 13, 2018

This might have regressed with #3059.

@ebruchez

This comment has been minimized.

Collaborator

ebruchez commented Mar 13, 2018

Following #3059, upon xforms-enabled, we set current-case-id to the value of $last-available-and-visited-case-id.

But since section status is only collected for top-level sections, $last-available-and-visited-section-id deals only with top-level sections. It gets the last available AND visited (per @fr:section-status) section, defaulting to the first relevant top-level section.

Logically, it follows that:

  • either section status should apply to the same level as wizard pages
  • or we should set current-case-id to some other value and not a top-level section
@ebruchez

This comment has been minimized.

Collaborator

ebruchez commented Mar 13, 2018

Ideally we should have an option to handle subsections/grids the same way we handle top-level sections, with controlled navigation and status for each page. But we can make this a separate RFE as it is an important change.

So we should set current-case-id to something reasonable, which could be the first subsection/grid of the top-level section found with $last-available-and-visited-section-id.

@ebruchez ebruchez closed this in 931d75a Mar 13, 2018

@ebruchez ebruchez added this to Done in Orbeon Forms 2018.1 via automation Mar 13, 2018

Orbeon Forms 2017.2.1 automation moved this from In progress to Done Mar 13, 2018

@ebruchez

This comment has been minimized.

Collaborator

ebruchez commented Mar 13, 2018

  • set current-case-id
  • check if we need to fix fr-section-shown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment