New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label disappears when clicking quickly #3449

Closed
ebruchez opened this Issue Jan 15, 2018 · 3 comments

Comments

Projects
2 participants
@ebruchez
Collaborator

ebruchez commented Jan 15, 2018

From user:

I set a label for a field (like text field) and then click right away on the settings button to set for instance the field as mandatory, the label disappears after I click on the Apply button.

@ebruchez ebruchez self-assigned this Jan 15, 2018

@ebruchez ebruchez added this to To do in Orbeon Forms 2017.2.1 via automation Jan 15, 2018

@ebruchez ebruchez added the Usability label Jan 15, 2018

@avernet

This comment has been minimized.

Collaborator

avernet commented Jan 15, 2018

I also reproduced this.

@ebruchez ebruchez added this to To Do in Orbeon Forms 2018.1 Jan 31, 2018

@ebruchez ebruchez moved this from To do to In progress in Orbeon Forms 2017.2.1 Feb 9, 2018

@ebruchez

This comment has been minimized.

Collaborator

ebruchez commented Feb 9, 2018

@ebruchez

This comment has been minimized.

Collaborator

ebruchez commented Feb 9, 2018

This is happening because of the order of events sent by the client:

<xxf:event name="xxforms-rpc-request" source-control-id="#document">
    <xxf:property name="id">4</xxf:property>
    <xxf:property name="path">org/orbeon/builder/rpc/FormBuilderRpcApi/controlEditDetails</xxf:property>
    <xxf:property name="args">{&quot;controlId&quot;:&quot;fb≡section-1-section≡grid-1-grid≡control-1-control&quot;}</xxf:property>
</xxf:event>
<xxf:event name="xxforms-rpc-request" source-control-id="#document">
    <xxf:property name="id">5</xxf:property>
    <xxf:property name="path">org/orbeon/builder/rpc/FormBuilderRpcApi/controlUpdateLabelOrHintOrText</xxf:property>
    <xxf:property name="args">{&quot;controlId&quot;:&quot;fb≡section-1-section≡grid-1-grid≡control-1-control&quot;,&quot;lhha&quot;:&quot;label&quot;,&quot;value&quot;:&quot;abcwef&quot;,&quot;isHTML&quot;:false}</xxf:property>
</xxf:event>

So the first event to be dispatched is the click on the settings icon, and the second one is the update to the label.

Could we just setTimeout the click on the Control Settings icon to ensure that any other pending events are processed first? Not sure if that can have any other drawbacks. And even if we do that, couldn't the event still be first in line?

@avernet avernet closed this in 96baa02 Feb 9, 2018

Orbeon Forms 2018.1 automation moved this from To Do to Done Feb 9, 2018

Orbeon Forms 2017.2.1 automation moved this from In progress to Done Feb 9, 2018

@avernet avernet assigned avernet and unassigned ebruchez Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment