Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property to setup whether a provider supports reindexing #3486

Closed
avernet opened this Issue Feb 24, 2018 · 4 comments

Comments

Projects
1 participant
@avernet
Copy link
Collaborator

avernet commented Feb 24, 2018

Without such a property, custom providers can't have their /reindex called.

+1 from user

@avernet

This comment has been minimized.

Copy link
Collaborator Author

avernet commented Feb 26, 2018

This shouldn't be unlike what we are doing for the lease property (see oxf.fr.persistence.*.lease defined in properties-form-runner.xml).

@avernet

This comment has been minimized.

Copy link
Collaborator Author

avernet commented Mar 2, 2018

The sealed trait Provider is confusing, as object contain a name, which in general is the same as the provider name used in the properties (e.g. mysql), but it could also be different, e.g. if the user has a provider named dev-mysql. This case is supported as we get he Provider.name from the path. But Provider.name isn't necessarily the provider name. To avoid this confusion, I've renamed this name everywhere in pathToken.

avernet added a commit that referenced this issue Mar 2, 2018

avernet added a commit that referenced this issue Mar 5, 2018

@avernet avernet closed this in bdb8ef6 Mar 5, 2018

avernet added a commit that referenced this issue Mar 5, 2018

@avernet avernet added this to Done in Orbeon Forms 2018.1 via automation Mar 5, 2018

@avernet avernet added this to To do in Orbeon Forms 2017.2.1 via automation Mar 5, 2018

@avernet

This comment has been minimized.

Copy link
Collaborator Author

avernet commented Mar 5, 2018

Also cherry-picked for 2017.2-pe.

@ebruchez ebruchez moved this from To do to Done in Orbeon Forms 2017.2.1 Mar 5, 2018

@avernet

This comment has been minimized.

Copy link
Collaborator Author

avernet commented Mar 6, 2018

Partial support for reindexing in third-party implementation is now documented.

ebruchez added a commit that referenced this issue Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.