New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible section breaks editor icons #3530

Closed
ebruchez opened this Issue Mar 23, 2018 · 1 comment

Comments

Projects
1 participant
@ebruchez
Collaborator

ebruchez commented Mar 23, 2018

I reproduce this with Orbeon Forms 2017.2 and 2017.2.1, but not with the latest master.

There is a JavaScript error, probably because the section title is searched and not found, as when the section is not collapsible the title is an output instead of a trigger.

There is also the question of whether a section marked as non-collapsible in the builder should appear as such in the builder. For example Form Builder closes sections for large forms, and if those are not collapsible, the user won't be able to open them again.

+1 from customer

@ebruchez ebruchez self-assigned this Mar 23, 2018

@ebruchez ebruchez closed this in f8e446d Mar 27, 2018

@ebruchez ebruchez added this to Done in Orbeon Forms 2017.2.2 via automation Mar 27, 2018

@ebruchez

This comment has been minimized.

Collaborator

ebruchez commented Mar 27, 2018

On master, things didn't crash, but the section icons wouldn't show.

@ebruchez ebruchez added this to Done in Orbeon Forms 2018.1 May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment