New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5-column grid should be migrated to a better layout #3594

Closed
ebruchez opened this Issue May 17, 2018 · 2 comments

Comments

Projects
1 participant
@ebruchez
Collaborator

ebruchez commented May 17, 2018

We didn't think that many users would use 5-column grids, as you need to change Form Builder properties to allow for more than 4 columns, but some do.

Right now, a 5-column grid becomes the 5 first columns of a 12-column grid, which is not what users expect.

We need a divisor of 12, and obviously 5 isn't one, but we could do 10 columns out of 12 instead, which would be better.

See also #3423.

@ebruchez ebruchez changed the title from column to 5-column grid should be migrated to a better layout May 17, 2018

@ebruchez

This comment has been minimized.

Collaborator

ebruchez commented May 17, 2018

@ebruchez

This comment has been minimized.

Collaborator

ebruchez commented May 17, 2018

One issue is that if you have already loaded an older form Form Builder, it will have the new layout with <fr:c> already. I don't think we can automatically convert the form to 10-out-of-12 columns from there. So for now the scope of this bug is only to handle forms that haven't been loaded and saved by Orbeon Forms 2017.2 yet.

@ebruchez ebruchez closed this in 4c8596b May 17, 2018

@ebruchez ebruchez added this to Done in Orbeon Forms 2018.1 via automation May 17, 2018

@ebruchez ebruchez added this to Done in Orbeon Forms 2017.2.2 via automation May 17, 2018

ebruchez added a commit that referenced this issue May 17, 2018

ebruchez added a commit that referenced this issue May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment