Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section titles must support HTML #3671

Closed
ebruchez opened this issue Aug 9, 2018 · 2 comments

Comments

Projects
2 participants
@ebruchez
Copy link
Collaborator

commented Aug 9, 2018

The dialog has the "HTML" checkbox, but when enabling it, the section title actually shows, for example:

<div>Untitled <strong>Section</strong></div>

@ebruchez ebruchez self-assigned this Aug 9, 2018

@ebruchez ebruchez added this to To review in Orbeon Forms 2018.1.3 Oct 24, 2018

@ebruchez ebruchez removed this from Todo in Orbeon Forms 2018.1.2 Oct 24, 2018

@ebruchez ebruchez removed this from To review in Orbeon Forms 2018.1.3 Nov 13, 2018

@avernet

This comment has been minimized.

Copy link
Collaborator

commented Mar 25, 2019

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 25, 2019

What would it take? The dialog does the right thing:

<xf:label ref="$form-resources/section-1/label" mediatype="text/html"/>

<fr:section> uses the custom-lhha mode and accesses the label with xxf:label('fr-section'), used like this:

<xsl:choose>
    <xsl:when test="$collapsible">
        <xf:trigger appearance="minimal" class="fr-section-label fr-section-{{if ($open) then 'open' else 'closed'}}">
            <xf:label value="xxf:label('fr-section')"/>
            <xf:help  value="xxf:help('fr-section')"/>
            <xf:hint  value="xxf:hint('fr-section')"/>
        </xf:trigger>
    </xsl:when>
    <xsl:otherwise>
        <xf:output appearance="minimal" class="fr-section-label" value="xxf:label('fr-section')">
            <xf:help  value="xxf:help('fr-section')" />
            <xf:hint  value="xxf:hint('fr-section')" />
        </xf:output>
    </xsl:otherwise>
</xsl:choose>

We'd need to propagate the mediatype="text/html" attribute statically, as we cannot obtain it dynamically at this point.

@ebruchez ebruchez added this to To do in Orbeon Forms 2018.2.3 via automation Mar 25, 2019

ebruchez added a commit that referenced this issue Mar 25, 2019

@ebruchez ebruchez closed this Mar 25, 2019

@ebruchez ebruchez added this to Done in Orbeon Forms 2019.1 via automation Mar 25, 2019

Orbeon Forms 2018.2.3 automation moved this from To do to Done Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.