New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox, IE, Edge: Review asks to leave page #3718

Closed
ebruchez opened this Issue Sep 5, 2018 · 4 comments

Comments

Projects
1 participant
@ebruchez
Collaborator

ebruchez commented Sep 5, 2018

screen shot 2018-09-05 at 12 11 07 pm

screen shot 2018-09-05 at 12 06 44 pm

@ebruchez ebruchez added the Form Runner label Sep 5, 2018

@ebruchez ebruchez self-assigned this Sep 5, 2018

@ebruchez ebruchez added this to In Progress in Orbeon Forms 2018.1 Sep 5, 2018

@ebruchez

This comment has been minimized.

Show comment
Hide comment
@ebruchez

ebruchez Sep 5, 2018

Collaborator

Now I can't reproduce it.

Collaborator

ebruchez commented Sep 5, 2018

Now I can't reproduce it.

@ebruchez

This comment has been minimized.

Show comment
Hide comment
@ebruchez

ebruchez Sep 5, 2018

Collaborator

It happens after doing Edit → Review → Edit. This didn't happen with 2017.2.

Collaborator

ebruchez commented Sep 5, 2018

It happens after doing Edit → Review → Edit. This didn't happen with 2017.2.

@ebruchez

This comment has been minimized.

Show comment
Hide comment
@ebruchez

ebruchez Sep 5, 2018

Collaborator

Interesting that even with Chrome, going back to Edit does setDataStatus: false, yet the handler doesn't kick in in this case.

Collaborator

ebruchez commented Sep 5, 2018

Interesting that even with Chrome, going back to Edit does setDataStatus: false, yet the handler doesn't kick in in this case.

@ebruchez

This comment has been minimized.

Show comment
Hide comment
@ebruchez

ebruchez Sep 5, 2018

Collaborator

Actually it sets it totrue just before navigating, so that's fine under Chrome.

It might be because xxf:server-events and xxf:submission is sent and processed before xxf:script. xxf:submission should be last.

Collaborator

ebruchez commented Sep 5, 2018

Actually it sets it totrue just before navigating, so that's fine under Chrome.

It might be because xxf:server-events and xxf:submission is sent and processed before xxf:script. xxf:submission should be last.

@ebruchez ebruchez added the Regression label Sep 5, 2018

@ebruchez ebruchez closed this in 75c5d17 Sep 5, 2018

Orbeon Forms 2018.1 automation moved this from In Progress to Done Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment