New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date picker doesn't use right language when embedded #3787

Closed
ebruchez opened this Issue Oct 23, 2018 · 2 comments

Comments

1 participant
@ebruchez
Collaborator

ebruchez commented Oct 23, 2018

+1 from customer

Compare:

screen shot 2018-10-23 at 3 20 01 pm

screen shot 2018-10-23 at 3 20 11 pm

@ebruchez

This comment has been minimized.

Collaborator

ebruchez commented Oct 23, 2018

  • also check/fix with new date picker (once done with #3657)

@ebruchez ebruchez added this to To review in Orbeon Forms 2018.1.3 Oct 24, 2018

@ebruchez

This comment has been minimized.

Collaborator

ebruchez commented Oct 31, 2018

components.xsl places a lang attribute on the root html element:

<xh:html
    lang="{{xxf:instance('fr-language-instance')}}"
    xml:lang="{{xxf:instance('fr-language-instance')}}">

The result is something like:

<html lang="en" id="xf-1">

When embedding, this is lost. We need an element which is not the root element of the document, and which has the correct id so that it can be updated.

@ebruchez ebruchez closed this in e61ac1f Oct 31, 2018

@ebruchez ebruchez added this to Done in Orbeon Forms 2017.2.3 via automation Oct 31, 2018

@ebruchez ebruchez added this to Done in Orbeon Forms 2018.2 Nov 7, 2018

@ebruchez ebruchez moved this from To review to Done in Orbeon Forms 2018.1.3 Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment