New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed PDF output if cells all have colspan #3799

Closed
ebruchez opened this Issue Oct 26, 2018 · 0 comments

Comments

1 participant
@ebruchez
Collaborator

ebruchez commented Oct 26, 2018

Example source grid:

<fr:c x="1" y="5" w="4" h="3">
    ...
</fr:c>
<fr:c x="5" y="5" w="4" h="3">
    ...
</fr:c>
<fr:c x="9" y="5" w="4" h="3">
    ...
</fr:c>
<fr:c x="1" y="8" w="5">
    ...
</fr:c>
<fr:c x="6" y="8" w="7" h="1"/>

Example HTML produced:

<tr class="fr-grid-tr">
    <td id="section-2-section≡grid-3-grid≡xf-661" class="fr-grid-td xforms-group" colspan="4" rowspan="3">
    ...
    </td>
    <td id="section-2-section≡grid-3-grid≡xf-670" class="fr-grid-td xforms-group" colspan="4" rowspan="3">
    ...
    </td>
    <td id="section-2-section≡grid-3-grid≡xf-672" class="fr-grid-td xforms-group" colspan="4" rowspan="3">
    ...
    </td>
</tr>
<tr class="xforms-hidden"/>
<tr class="xforms-hidden"/>
<tr class="fr-grid-tr">
    ...
</tr>

The XSLT preprocessing for PDF adds xforms-hidden on the rows which don't have controls. This was done with #2004. Then with #2414, we did this in CSS. Can we revert #2004 now that we have #2414?

+1 from customer

@ebruchez ebruchez self-assigned this Oct 26, 2018

@ebruchez ebruchez closed this in 295c8f3 Oct 26, 2018

@ebruchez ebruchez added this to Done in Orbeon Forms 2017.2.3 via automation Oct 26, 2018

@ebruchez ebruchez added this to Done in Orbeon Forms 2018.2 Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment