New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help resizes repeated grid in Bookshelf form #3871

Closed
ebruchez opened this Issue Dec 31, 2018 · 4 comments

Comments

Projects
2 participants
@ebruchez
Copy link
Collaborator

ebruchez commented Dec 31, 2018

screen shot 2018-12-31 at 3 45 45 pm

@avernet

This comment has been minimized.

Copy link
Collaborator

avernet commented Jan 22, 2019

The div.popover is added inside a tr, after a th, which doesn't seem like a good place. This is because we don't recognize the help as being "standalone", that is outside of the control, and not referring to the control. The code in xforms.js expects those LHHA to have an id ending with ≡≡p with the help, but this isn't the case here.

This must have regressed when we changed how we output the LHH in the table headers. Adding code to handle those standalone LHH "controls" solves the problem.

@avernet

This comment has been minimized.

Copy link
Collaborator

avernet commented Jan 22, 2019

I also checked that things still work fine if we have an xf:help for="…", even if we don't have this case anymore for table headers.

@avernet avernet closed this in e5a4300 Jan 22, 2019

@avernet avernet moved this from To do to Done in Orbeon Forms 2018.2.1 Jan 22, 2019

@ebruchez ebruchez reopened this Jan 23, 2019

@ebruchez

This comment has been minimized.

Copy link
Collaborator Author

ebruchez commented Jan 23, 2019

Reopening as the commit is breaking buttons (and possibly more).

avernet added a commit that referenced this issue Jan 24, 2019

@avernet

This comment has been minimized.

Copy link
Collaborator

avernet commented Jan 24, 2019

Fixed issue with buttons, closing.

@avernet avernet closed this Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment